Problem on dup_zz_zassenhaus?

32 views
Skip to first unread message

Lagamura Chess

unread,
May 11, 2020, 3:38:39 AM5/11/20
to sympy
Hello to everybody,

Assisting my professor we managed to make an improvement on the dup_zz_mignotte_bound which has been just pulled a few days ago.
Although, as i was trying to compare the impact in factor() i observed that in dup_zz_zassenhaus instead of calling dup_zz_mignotte_bound the old bound
has been used locally, making mignotte useless practically. So i create another PR #19280 changing that, but a weird issue occurred  in an inequality as Kalevi Suominen pointed out.

Can anyone give a look in that?

thanks a lot,
Stelios

Kalevi Suominen

unread,
May 11, 2020, 5:45:58 AM5/11/20
to sympy
Zassenhaus' algorithm has been taken from the book of von zur Gathen and Gerhard (Algorithm 15.19). The bound B
is there given explicitly in a form that is equivalent to the one in dup_zz_zassenhaus ("the old bound"). It seems that it is necessary for the validity of the algorithm. There are better bounds for estimating the size of the roots but they are not suitable for Zassenhaus' algorithm.

Kalevi Suominen

Lagamura Chess

unread,
May 16, 2020, 6:13:27 AM5/16/20
to sympy

We made some changes, and now Travis CI gives timeout because no output was recieved.
This means something like an infinite loop? How can i debug this?

Aaron Meurer

unread,
May 18, 2020, 5:20:47 PM5/18/20
to sympy
You will need to run the tests yourself on your computer to see where
they hang. If you interrupt the hanging test with Control-C, it will
give you a traceback that will tell you where it was when you stopped
it.

See https://github.com/sympy/sympy/wiki/Development-workflow#be-sure-that-all-tests-of-sympy-pass
about running the tests.

Aaron Meurer
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/7a218d4b-498c-4bf9-8007-ba55f64aa6a8%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages