[diffgeom] - stale TODOs

24 views
Skip to first unread message

AB

unread,
Jan 17, 2026, 11:52:21 AM (yesterday) Jan 17
to sympy
Hello sympy maintainers,

I was checking the TODOs inside the diffgeom module and found a 2 of them which were already working 
all I did was remove the comments on the asserts and just run the tests


def test_point():
    point = Point(cs, [x, y])
    assert point != Point(cs, [2, y])
    #TODO assert point.subs(x, 2) == Point(cs, [2, y])
    #TODO assert point.free_symbols == set([x, y])



were just changed to:
def test_point():
    point = Point(cs, [x, y])
    assert point != Point(cs, [2, y])
    assert point.subs(x, 2) == Point(cs, [2, y])
    assert point.free_symbols == set([x, y])

all tests passed, they worked on isympy as well (just to double check)
are these stale TODOs? shld I create a PR for them ??
or are they supposed to remain commented

Thanks, Ayush

Aaron Meurer

unread,
12:04 PM (6 hours ago) 12:04 PM
to sy...@googlegroups.com
You could check where they came from in the git history (using git
blame or the blame interface on github), and see if they used to fail.

Aaron Meurer
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/sympy/c2747e7e-b346-40ba-a676-3a7af520ddd1n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages