template for PR's opening paragraph

29 views
Skip to first unread message

Chris Smith

unread,
Mar 12, 2017, 9:38:20 PM3/12/17
to sympy
The markdown syntax for comments is

<!---
your comment goes here
and here
-->


When I create a new pull request from a branch, I get the following boilerplate comment in the opening paragraph

<!-- If this pull request fixes an issue please indicate which issue by typing "Fixes #NNNN" below.>


It needs a `--` before the `>` at the end of the line, otherwise nothing that is typed below is seen (since it is part of an unterminated comment.

Is that under our control or is that a Github issue?

/c

Aaron Meurer

unread,
Mar 12, 2017, 9:50:50 PM3/12/17
to sy...@googlegroups.com
I didn't realize that was happening. It should be fixed. The text for
it is in the file PULL_REQUEST_TEMPLATE.md. I also have another fix to
that file here https://github.com/sympy/sympy/pull/12122.

Aaron Meurer
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sympy+un...@googlegroups.com.
> To post to this group, send email to sy...@googlegroups.com.
> Visit this group at https://groups.google.com/group/sympy.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sympy/72cfaa5e-d8fc-4b70-ac6a-33cea34b63fe%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages