failures in master

[Chris Smith]

How does one tell in which file a raw docstring is needed?

[Chris Smith]

There are failures in this PR and I don't know what is causing them.

[Chris Smith]

(Now it occurs to me that the failure may not be in master; I just assumed that it was because the PR I cite doesn't have any special escapes in the docstring.)

On Sunday, August 13, 2017 at 8:34:24 PM UTC-5, Chris Smith wrote:

[Aaron Meurer]

Looks like the check I implemented is also inadvertently the place where the tests will fail if there is any syntax error. So I'm thinking python -m compileall isn't the greatest way to test for this. 

I'm almost to the point of just removing the invalid escape checks. They will be syntax error probably in Python 3.7 or 3.8, so maybe we should just wait until those are released and we support them, and it will be much easier to test for them.

Unless someone can think of a better way to test them. The problem is that they are only checked when the Python bytecode is compiled, and only when Python is run with the -We:invalid flag. So if the bytecode has already been compiled and -We:invalid wasn't included, it won't error. Furthermore, when setup.py install is run, Python byte compiles all the files and just happily ignores syntax errors, meaning we can't rely on this particular bytecode compilation to do the check for us. 

I already implemented two incorrect checks that weren't really erroring (almost three, but I was more careful by then). Now we have a check that works, but the messaging is awful.

Aaron Meurer

--
You received this message because you are subscribed to the Google Groups "sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscribe@googlegroups.com.
To post to this group, send email to sy...@googlegroups.com.
Visit this group at https://groups.google.com/group/sympy.
To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/ec6add2e-5a0d-473e-847c-728bf45d12ef%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.