Doubt Regarding .mailmap file

66 views
Skip to first unread message

Shishir Kushwaha

unread,
Feb 2, 2024, 12:36:10 PM2/2/24
to sympy
Do I need to add my details everytime to thee .mailmap file when making a PR , I did it in my first PR as mentioned in the documentation but when creating a new comitt on another issue , the authro test was failing even though my name is there in the file already . Any idea why this could happen?
 
Screenshot 2024-02-02 230515.png

Aaron Meurer

unread,
Feb 2, 2024, 4:56:34 PM2/2/24
to sy...@googlegroups.com
Is the name and email there the same as the one you added? If you
changed the spelling of your name or the email, you have to add
another entry to .mailmap. The point of .mailmap is to indicate when
two different name/emails are actually the same person.

Otherwise, I suspect the issue is that you have not synchronized the
upstream master branch which contains your change to .mailmap.

Normally, you should only ever need to add yourself to .mailmap once.
After that, you never need to do it again, unless, like I said, you
create commits with a different spelling of your name or a different
email.

Aaron Meurer

On Fri, Feb 2, 2024 at 10:36 AM Shishir Kushwaha
<kushwahas...@gmail.com> wrote:
>
> Do I need to add my details everytime to thee .mailmap file when making a PR , I did it in my first PR as mentioned in the documentation but when creating a new comitt on another issue , the authro test was failing even though my name is there in the file already . Any idea why this could happen?
>
>
> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sympy+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/d9705b06-6ca2-49af-9648-e0f23499a6b7n%40googlegroups.com.

Oscar Benjamin

unread,
Feb 2, 2024, 5:31:06 PM2/2/24
to sy...@googlegroups.com
It's hard to tell from a screenshot. Do you have a link to the PR?

On Fri, 2 Feb 2024 at 17:36, Shishir Kushwaha
<kushwahas...@gmail.com> wrote:
>
> Do I need to add my details everytime to thee .mailmap file when making a PR , I did it in my first PR as mentioned in the documentation but when creating a new comitt on another issue , the authro test was failing even though my name is there in the file already . Any idea why this could happen?
>
>

Shishir Kushwaha

unread,
Feb 3, 2024, 1:35:36 AM2/3/24
to sympy
Yes i forgot to sync with the upstream before creating the changes , It is solved now . Thank you for your time and help .

ABHISHEK KUMAR

unread,
Feb 3, 2024, 3:24:34 AM2/3/24
to sy...@googlegroups.com
No, if you are a contributor, you don't need to include it in.mailmap. You just need to sync up the changes in the base branch and your name will reflect back there.

On Fri, 2 Feb 2024, 11:06 pm Shishir Kushwaha, <kushwahas...@gmail.com> wrote:
Do I need to add my details everytime to thee .mailmap file when making a PR , I did it in my first PR as mentioned in the documentation but when creating a new comitt on another issue , the authro test was failing even though my name is there in the file already . Any idea why this could happen?
 

--

Ankit Kumar Singh

unread,
Feb 3, 2024, 3:24:35 AM2/3/24
to sy...@googlegroups.com
Refresh your current branch with the master branch and make sure your name is in the mailmap file.

On Fri, Feb 2, 2024, 11:06 PM Shishir Kushwaha <kushwahas...@gmail.com> wrote:
Do I need to add my details everytime to thee .mailmap file when making a PR , I did it in my first PR as mentioned in the documentation but when creating a new comitt on another issue , the authro test was failing even though my name is there in the file already . Any idea why this could happen?
 

--
Reply all
Reply to author
Forward
0 new messages