[sympy] WIP - trigsimp modifications (#1690)
Christopher Smith
You can merge this Pull Request by running:
git pull https://github.com/smichr/sympy trig
Or view, comment on, or merge it at:
https://github.com/sympy/sympy/pull/1690
Commit Summary
- trigsimp modifications
File Changes
- M sympy/simplify/simplify.py (159)
- M sympy/simplify/tests/test_simplify.py (25)
Patch Links
—
Reply to this email directly or view it on GitHub.
Christopher Smith
@asmeurer, maybe I can bring back some of the features of the old trigsimp branch. These are some pretty basic modifications with a few new patterns.
Aaron Meurer
SymPy Bot Summary: 
Failed after merging smichr/trig (ea33d48) into master (9c41978).
@smichr: Please fix the test failures.
Python 2.5.0-final-0: fail
Python 2.6.6-final-0: fail
Python 2.7.2-final-0: fail
Python 2.6.8-final-0: pass
Python 2.7.3-final-0: pass
PyPy 2.0.0-beta-1; 2.7.3-final-42: pass
Python 3.2.2-final-0: pass
Python 3.3.0-final-0: pass
Python 3.2.3-final-0: pass
Python 3.3.0-final-0: pass
Python 3.3.0-final-0: pass
**Sphinx 1.1.3:** fail
Aaron Meurer
Could you write a more descriptive commit message?
Christopher Smith
Before I remove the WIP there will be something more descriptive.
Christopher Smith
Closed #1690.
Christopher Smith
To get back to where #772 is going to take more time than I can give right now so I'll close this.
Christopher Smith
Reopened #1690.
Christopher Smith
I gave it another try today...let's see how it goes with tests.
Christopher Smith
issues addressed can be found by searching for PR 772 in the issues (#772).
Christopher Smith
Don't commit -- tests need to be added for the patterns.
Aaron Meurer
Even if you can't get to it, I would still leave it open. There's a chance someone else will pick up the work. At the very least, if you close it, open an issue about it, so that the work is not lost completely.