Fix for the polynomials docstring test.

2 views
Skip to first unread message

Christian Muise

unread,
Apr 6, 2010, 3:24:28 PM4/6/10
to sympy-patches
The output from the following polynomials function has the order of
arguments wrong (although mathematically correct):
- solve_poly_system([y**2 - x**3 + 1, y*x], x, y)

This was causing a test to fail.

Git repo: git://github.com/haz/sympy.git
Branch: doc-test

Cheers

Vinzent Steinberg

unread,
Apr 6, 2010, 4:36:05 PM4/6/10
to sympy-...@googlegroups.com
2010/4/6 Christian Muise <christi...@gmail.com>:

I think your patch does not fix the problem, because the order is
platform-dependent. This is due to hash() returning different values
among different platforms (especially 32 and 64 bit). The polys8
branch of Mateusz fixes this problem correctly I think.

Vinzent

Christian Muise

unread,
Apr 6, 2010, 4:42:48 PM4/6/10
to sympy-...@googlegroups.com
Ahh, well that explains things. Please ignore then ;).

  Cheers


--
You received this message because you are subscribed to the Google Groups "sympy-patches" group.
To post to this group, send email to sympy-...@googlegroups.com.
To unsubscribe from this group, send email to sympy-patche...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.


Aaron S. Meurer

unread,
Apr 6, 2010, 4:53:28 PM4/6/10
to sympy-...@googlegroups.com
Actually, all the tests pass for me in his branch on both architectures.  

And I think Mateusz must have changed the algorithm itself in his branch, because the doctest is the same there.

Aaron Meurer
Reply all
Reply to author
Forward
0 new messages