Some advices

[Massimiliano Arione]

Hi,
since I started to use this plugin in a project of mine, I would like
to point out some issues:

- payment_form_tag_for() writes a form with attribute "POST", that's
not always valid (should be "post")
- sfPaymentPayPal class uses url_for() function. This sounds like an
ugly hack to me: helper functions are meant to be used exclusively in
the view, not in the model.
- sfPaymentPayPal module uses some counter-intuitive templates named
like "failureSuccess": it could be better with "sampleFailure", using
return values in actions instead of setTemplate().
- I dont' see the reason to introduce a test mode instead of
exploiting on the symfony environments.
- the code is missing some comments and often is failing to respect
symfony conventions (this decrease readability)

I hope this can help to improve.

cheers
Massimiliano

[Massimiliano Arione]

One more: isCompleted() method in sfPaymentPayPal should check for
$this->ipnData['payment_status'] being not empty, otherwise a php
notice is raised.

[Antoine Leclercq]

Hi Massimiliano,

Thanks for your feedbacks. They're welcome as we are reviewing the plugin right now.

Feel free to go on in your contribution by registering as a developer for the plugin and fixing what you think should be.

All the best,

Antoine

--

You received this message because you are subscribed to the Google Groups "symfony payment developers" group.
To post to this group, send email to symfony-payme...@googlegroups.com.
To unsubscribe from this group, send email to symfony-payment-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/symfony-payment-developers?hl=en.

[Massimiliano Arione]

On 11 Dic, 12:03, Antoine Leclercq <antoine.lecle...@gmail.com> wrote:
> Thanks for your feedbacks. They're welcome as we are reviewing the plugin
> right now.
>
> Feel free to go on in your contribution by registering as a developer for
> the plugin and fixing what you think should be.

OK, I signed as developer and I'm glad you accepted me.
Some of issues I noticed above are of course smaller and immediate to
fix: easy to convert POST to post ;-)
But for other ones, I would like to listen for other opinions before
to touch the code, since most of them involve core portions of plugin

[Antoine Leclercq]

Hi Massimiliano,

Thanks for registering as a contributor.

A quick history on the development of the plugin :

 - We started building a community this summer

 - Johnny started the development during the summer taking into account the first community comments

 - Jiappo continued the development brought to life some of the community requirements (transaction storage, cart...)

 - Marijn is currently contributing on the plugin

As a starting point, I would advise you to read the discussion we had with Marijn and Bertrand about the plugin structure and orientation.

All the best,

Antoine