Preferred way of submitting contributions and patches

[Flyingmana]

Hi,

i have two patches for the sandbox, more will coming.

So, how do you prefer to get them in the current state?
Should I send Pull-Requests? will you have a look at my repositories by yourself?

Next point is, i saw you added the bundles in the sandbox hard-coded.

Funny about this is, controller Classes are loaded from the Vendor directory, Templates from your hard added directory.
I think you will change to use the Vendor one completely soon?
Else it would need to maintain two repositories, what could get difficult i think.
Or is there a reason i did not see?

[Paweł Jędrzejewski]

Hey!

Just send a pull request to GitHub repo. ;)

I have a lot of work recently, but I should finish today a Contribution guide, which should clarify everything about patches and collaboration.

There is a reason for this, bundles in /src directory are application specific, they won't be reused in any other app.

The contain customized Entities, needed services, configuration and templates ( they override the ones in /vendor/bundles ).

You probably didn't notice that all Sandbox bundles extend the main Sylius bundles, which have their own repos and are the true power.

For example SandboxAssortmentBundle extends SyliusAssortmentBundle, mainly to modify the templates and organize all related code.

For the main Sylius app I plan to have only one SyliusCoreBundle to tie all other togather, as the templates overriding will be handled by theming bundle.

Bundle inheritance is well described in Symfony2 docs I think.

I also will write a documentation article about Architectural concepts behind Sylius bundles.

Thanks a lot for the patches, It really makes me happy to see poeple helping on Sylius.

Please sent 2 separate pull requests. : )

Bests,

Paweł. 

[Flyingmana]

great =)

I have to admit, this is the first symfony Project i work on. I already read much about it, but did not work on one yet. So it could happen, that i dont know enough about certain symfony concepts.

Can you give me advice about how to test the main Silius Bundles for cases like the missing CSRF Tocken in Cart Template?
Could this get tested with unittests and can you show me one for this? Than I would try to work with the unittests for the next problems i find.