Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[PATCH 2/2] network_thread: remove old DEBUG_IPC ifdefs

8 views
Skip to first unread message

Dominique Martinet

unread,
Jul 7, 2024, 8:15:36 PM7/7/24
to stefan...@swupdate.org, swup...@googlegroups.com, Dominique Martinet
These ifdef are no longer used and do not even work correctly (manually
defining DEBUG_IPC will dead lock on msglock); remove them.

Signed-off-by: Dominique Martinet <dominique...@atmark-techno.com>
---
core/network_thread.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/core/network_thread.c b/core/network_thread.c
index d7b713fb2154..b70fa12cf4ee 100644
--- a/core/network_thread.c
+++ b/core/network_thread.c
@@ -424,9 +424,6 @@ void *network_thread (void *data)
close(ctrlconnfd);
continue;
}
-#ifdef DEBUG_IPC
- TRACE("request header: magic[0x%08X] type[0x%08X]", msg.magic, msg.type);
-#endif

should_close_socket = true;
pthread_mutex_lock(&stream_mutex);
@@ -513,9 +510,6 @@ void *network_thread (void *data)
nrmsgs--;
strncpy(msg.data.status.desc, notification->msg,
sizeof(msg.data.status.desc) - 1);
-#ifdef DEBUG_IPC
- DEBUG("GET STATUS: %s\n", msg.data.status.desc);
-#endif
msg.data.status.current = notification->status;
msg.data.status.error = notification->error;
}
--
2.39.2


Stefano Babic

unread,
Jul 8, 2024, 6:14:44 AM7/8/24
to Dominique Martinet, stefan...@swupdate.org, swup...@googlegroups.com
Applied to -master, thanks !

Best regards,
Stefano
Reply all
Reply to author
Forward
0 new messages