[PATCH][libubootenv] uboot_env: Fix libuboot_validate_flags() boolean type validation

[Christian Storm]

At this stage of validation, set ok_type and not ok_access.
Setting the latter skips validation entirely since ok_type
is initialized to true.

Make valid boolean values exactly the ones U-Boot accepts:
1/0, y/n, t/f, Y/N, T/F, yes/no, true/false.

Signed-off-by: Christian Storm <christi...@siemens.com>
---
src/uboot_env.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/uboot_env.c b/src/uboot_env.c
index e8db81a..23c15ee 100644
--- a/src/uboot_env.c
+++ b/src/uboot_env.c
@@ -201,10 +201,13 @@ static bool libuboot_validate_flags(struct var_entry *entry, const char *value)
ok_type = validate_int(true, value + 2);
break;
case TYPE_ATTR_BOOL:
- ok_access = (value[0] == '1' || value[0] == 'y' || value[0] == 't' ||
- value[0] == 'Y' || value[0] == 'T' ||
- value[0] == '0' || value[0] == 'n' || value[0] == 'f' ||
- value[0] == 'N' || value[0] == 'F') && (strlen(value) != 1);
+ ok_type = !strcmp(value, "1") || !strcmp(value, "0") ||
+ !strcmp(value, "y") || !strcmp(value, "n") ||
+ !strcmp(value, "t") || !strcmp(value, "f") ||
+ !strcmp(value, "Y") || !strcmp(value, "N") ||
+ !strcmp(value, "T") || !strcmp(value, "F") ||
+ !strcmp(value, "yes") || !strcmp(value, "no") ||
+ !strcmp(value, "true") || !strcmp(value, "false");
break;
case TYPE_ATTR_IP:
case TYPE_ATTR_MAC:
--
2.55.0

[Stefano Babic]

Applied to -master, thanks !

Best regards,
Stefano

--
_______________________________________________________________________
Nabla Software Engineering GmbH
Hirschstr. 111A | 86156 Augsburg | Tel: +49 821 45592596
Geschäftsführer : Stefano Babic | HRB 40522 Augsburg
E-Mail: sba...@nabladev.com