I'm sorry I'm so late for your reply.
> I do not think the issue exists.
I bitbake swupdate with poky and meta-oe without any modifications, depend error happens, isn't it an issue?
> In fact, CONFIG_MONGOOSESSL is protected by
> CONFIG_SSL_IMPL_OPENSSL or CONFIG_SSL_IMPL_MBEDTLS. If you set
> CONFIG_MONGOOSESSL, SSL is already set.
I don't find the relationship of CONFIG_MONGOOSESSL and CONFIG_SSL_IMPL_OPENSSL or CONFIG_SSL_IMPL_MBEDTLS in menuconfig step.
---------------------------
$ grep MONGOOSESSL tmp/work/core2-64-poky-linux/swupdate/2020.04-r0/git/ -r | grep Kconfig
$
---------------------------
By default CONFIG_SSL_IMPL_OPENSSL will be enable during configure step. But openssl is not in the dependences of swupdate. That' s why error happens by default.
Of course, YP users can fix this build error by manuconfig or modified the defconfig. But that's not friendly.
In fact, after configuring the CONFIG_SSL_IMPL_OPENSSL will be added into .config file. But swupdate.inc judges which dependence will be added by defconfig file before configure step.
So, I thought out two methods to fix this issue to make swupdate can be passed by default.
1. Added openssl into dependences by DEPENDS parameter, such as the following:
----------------------------
--- a/recipes-support/swupdate/swupdate.inc
+++ b/recipes-support/swupdate/swupdate.inc
@@ -72,7 +72,7 @@ S = "${WORKDIR}/git/"
......
-DEPENDS += "kern-tools-native"
+DEPENDS += "kern-tools-native openssl"
----------------------------
2. Added CONFIG_SSL_IMPL_OPENSSL into defconfig file.
----------------------------
--- a/recipes-support/swupdate/swupdate/defconfig
+++ b/recipes-support/swupdate/swupdate/defconfig
@@ -96,3 +96,4 @@ CONFIG_SHELLSCRIPTHANDLER=y
# CONFIG_ARCHIVE is not set
# CONFIG_REMOTE_HANDLER is not set
# CONFIG_BOOTLOADERHANDLER is not set
+CONFIG_SSL_IMPL_OPENSSL=y
----------------------------
Users who want to use mbedtls instead if openssl can added bbappend file to modify the DEPENDS parameter or defconfig file.
How about my suggestion?
Best regards
Zheng
________________________________________
发件人: Stefano Babic <sba...@denx.de>
发送时间: 2020年6月8日 16:55
收件人: Zheng, Ruoqin; Stefano Babic; yo...@yoctoproject.org
抄送: swupdate
主题: Re: [swupdate] RE: [yocto] [PATCH] [meta-swupdate] Fix build error of dependence.
--
You received this message because you are subscribed to the Google Groups "swupdate" group.
To unsubscribe from this group and stop receiving emails from it, send an email to swupdate+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/swupdate/647f2241-e847-1476-a294-7d4b4882e236%40denx.de.
So, the conclusion is adding a default SSL implementation option(CONFIG_SSL_IMPL_OPENSSL) into defconfig, is it?
Is there anybody plans to do it? Or let me submit a patch?
Best regards
Zheng Ruoqin
________________________________________
From: Stefano Babic <sba...@denx.de>
Sent: Thursday, June 18, 2020 16:22
To: Alexander Vickberg; Stefano Babic
Cc: Zheng, Ruoqin; yo...@yoctoproject.org; swupdate
Subject: Re: [swupdate] RE: [yocto] [PATCH] [meta-swupdate] Fix build error of dependence.
| mongoose/mongoose.c:4496:10: fatal error: openssl/ssl.h: No such file
or directory
Signed-off-by: Zheng Ruoqin <zhengr...@cn.fujitsu.com>
---
recipes-support/swupdate/swupdate/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/recipes-support/swupdate/swupdate/defconfig b/recipes-support/swupdate/swupdate/defconfig
index ffb3ea4..4e61f21 100644
--- a/recipes-support/swupdate/swupdate/defconfig
+++ b/recipes-support/swupdate/swupdate/defconfig
@@ -96,3 +96,4 @@ CONFIG_SHELLSCRIPTHANDLER=y
# CONFIG_ARCHIVE is not set
# CONFIG_REMOTE_HANDLER is not set
# CONFIG_BOOTLOADERHANDLER is not set
+CONFIG_SSL_IMPL_OPENSSL=y
--
2.17.1
> I guess you have just edited the file and you have not rerun a menuconfig. The
> file is then generated and some other CONFIG are still missing. I send a new
> patch with all changes, then.
Yes, I have just edited the file and rebuild the OSS. It was passed so I thought it was no problem.
Best regards,
Zheng
--
--------------------------------------------------
Zheng Ruoqin
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
ADDR.: No.6 Wenzhu Road, Software Avenue,
Nanjing, 210012, China
MAIL : zhengr...@cn.fujistu.com
Hi Zheng,