[PATCH] core: don't always say Image was corrupted on error

7 views
Skip to first unread message

Dominique Martinet

unread,
Jun 16, 2026, 12:45:23 AM (9 days ago) Jun 16
to swup...@googlegroups.com, Dominique Martinet
Valid images can fail installing for various reasons (user running
a script that failed, ENOSPC extracting data...), so it is misleading
to say that the image was "invalid or corrupted".

Reword to just say an error happened, messages above this error should
hopefully contain more useful information.
---

This is as much a RFC as a serious patch, but one of our dev
misunderstood this message thinking that the image was not downloaded
correctly on a subset of devices in a support request, so I think it'd
make sense to be more vague about the error here.

What do you think?


core/stream_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/stream_interface.c b/core/stream_interface.c
index 8680b755997b..6764d84efd8f 100644
--- a/core/stream_interface.c
+++ b/core/stream_interface.c
@@ -796,7 +796,7 @@ void *network_initializer(void *data)
}
} else {
inst.last_install = FAILURE;
- notify(FAILURE, RECOVERY_ERROR, ERRORLEVEL, "Image invalid or corrupted. Not installing ...");
+ notify(FAILURE, RECOVERY_ERROR, ERRORLEVEL, "Error happened. Not installing ...");
}

swupdate_progress_end(inst.last_install);
--
2.47.3


Reply all
Reply to author
Forward
0 new messages