Re: [PATCH 4/4] extended_config: Removed unused variable declarations

5 views
Skip to first unread message

Stefano Babic

unread,
Sep 19, 2025, 12:25:28 PM (12 days ago) Sep 19
to Alexander Dahl, swup...@googlegroups.com


On 9/19/25 08:42, Alexander Dahl wrote:
> gcc warned about those:
>
> [ 25%] Building C object src/CMakeFiles/ubootenv.dir/extended_config.c.o
> .../src/extended_config.c: In function 'consume_event':
> .../src/extended_config.c:274:33: warning: unused variable 'name' [-Wunused-variable]
> .../src/extended_config.c:84:13: warning: unused variable 'cdev' [-Wunused-variable]
>
> Signed-off-by: Alexander Dahl <a...@thorsis.com>
> ---
> src/extended_config.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/extended_config.c b/src/extended_config.c
> index c3782e1..4dfed39 100644
> --- a/src/extended_config.c
> +++ b/src/extended_config.c
> @@ -81,7 +81,6 @@ static int consume_event(struct parser_state *s, yaml_event_t *event)
> char *value;
> struct uboot_flash_env *dev;
> struct uboot_ctx *newctx;
> - int cdev;
>
> switch (s->state) {
> case STATE_START:
> @@ -271,7 +270,7 @@ static int consume_event(struct parser_state *s, yaml_event_t *event)
> case STATE_WRITELIST:
> switch (event->type) {
>
> - char *varflag, *name;
> + char *varflag;
> struct var_entry *entry;
>
> case YAML_MAPPING_START_EVENT:

Reviewed-by: Stefano Babic <stefan...@swupdate.org>
Reply all
Reply to author
Forward
0 new messages