Re: [sbabic/meta-swupdate] swupdate recipe not playing nice with devtool workflow (#2)

[Stefano Babic]

Hi Andrea,

please use the ML for your questions - I do not care about issues on github.

You can simply send to:

swup...@googlegroups.com

No registration required, it is fully open.

On 13/12/2016 08:33, Andrea Galbusera wrote:
> How to reproduce:
>
> * setup a Yocto stack with minimal dependencies as per README
> * run the following commands: attaching configuration and log for
> reference
>
> |$ devtool modify swupdate Parsing recipes..done. NOTE: Fetching
> swupdate... NOTE: Unpacking... NOTE: Patching... NOTE: Adding local
> source files to srctree... NOTE: Source tree extracted to
> /home/gizero/work/upstreaming/build/workspace/sources/swupdate NOTE:
> Recipe swupdate now set up to build from
> /home/gizero/work/upstreaming/build/workspace/sources/swupdate $ devtool
> build swupdate Build Configuration: BB_VERSION = "1.32.0" BUILD_SYS =
> "x86_64-linux" NATIVELSBSTRING = "universal" TARGET_SYS =
> "i586-poky-linux" MACHINE = "qemux86" DISTRO = "poky" DISTRO_VERSION =
> "2.2" TUNE_FEATURES = "m32 i586" TARGET_FPU = "" meta meta-poky
> meta-yocto-bsp meta-skeleton =
> "master:36e178a62f04e7f2611b26964efe46b9af97189a" meta-oe =
> "master:d9b5870edaddee69612dada2aa4bc2d8c3f70f44" meta-swupdate =
> "master:b794e0ef8adccaa70b05463d52d3fd49f0917bb6" workspace =
> "<unknown>:<unknown>" Initialising tasks: 100%
> |###########################################################################################################################################################################|
> Time: 0:00:01 NOTE: Executing SetScene Tasks NOTE: Executing RunQueue
> Tasks ERROR: swupdate-2016.10-r0 do_configure: oe_runmake failed ERROR:
> swupdate-2016.10-r0 do_configure: Function failed: do_configure (log
> file is located at
> /home/gizero/work/upstreaming/build/tmp/work/i586-poky-linux/swupdate/2016.10-r0/temp/log.do_configure.29840)
> ERROR: Logfile of failure stored in:
> /home/gizero/work/upstreaming/build/tmp/work/i586-poky-linux/swupdate/2016.10-r0/temp/log.do_configure.29840
> Log data follows: | DEBUG: Executing python function
> externalsrc_configure_prefunc | DEBUG: Python function
> externalsrc_configure_prefunc finished | DEBUG: Executing python
> function sysroot_cleansstate | DEBUG: Python function
> sysroot_cleansstate finished | DEBUG: Executing shell function
> do_configure | NOTE: make V=1 ARCH=i586 CROSS_COMPILE=i586-poky-linux-
> SKIP_STRIP=y oldconfig | ERROR: oe_runmake failed | make: *** No rule to
> make target 'oldconfig'. Stop. | WARNING: exit code 1 from a shell

It looks like there is not a defconfig. You need a defconfig for your
machine, there is no default because it makes no sense.

I just tested with a target of my own:

stefano@papero:/work/stefano/db-krogoth-twister$ devtool modify swupdate
Parsing recipes..done.
NOTE: Fetching swupdate...
remote: Counting objects: 426, done.
remote: Compressing objects: 100% (262/262), done.
remote: Total 426 (delta 305), reused 218 (delta 161)
Receiving objects: 100% (426/426), 513.60 KiB | 0 bytes/s, done.
Resolving deltas: 100% (305/305), completed with 92 local objects.
From file:///home/stefano/Projects/swupdate
67871cf..9bbd735 master -> master
+ d5525f3...7f1879e next -> next (forced update)
NOTE: Unpacking...
NOTE: Patching...
NOTE: Adding local source files to srctree...
NOTE: Source tree extracted to
/work/stefano/db-krogoth-twister/workspace/sources/swupdate
NOTE: Recipe swupdate now set up to build from
/work/stefano/db-krogoth-twister/workspace/sources/swupdate


> command. | ERROR: Function failed: do_configure (log file is located at
> /home/gizero/work/upstreaming/build/tmp/work/i586-poky-linux/swupdate/2016.10-r0/temp/log.do_configure.29840)
> ERROR: Task
> (/home/gizero/work/upstreaming/meta-swupdate/recipes-support/swupdate/swupdate_2016.10.bb:do_configure)
> failed with exit code '1' NOTE: Tasks Summary: Attempted 726 tasks of
> which 725 didn't need to be rerun and 1 failed. |
>
> Seems like the logic behind |devtool build| (which implies reconfiguring
> the source tree) is conflicting with how the tree is set up. I'm looking
> into it...

There is no default defconfig, and configure fails.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================

[Andrea Galbusera]

Hi Stefano,

First things first: thanks for quickly replying! I personally find github issues very convenient since it's easier for me to remember what I'm working on / expecting feedback for, but I understand your policy and I CCed the ML to this thread as well.

On Tue, Dec 13, 2016 at 9:16 AM, Stefano Babic <notifi...@github.com> wrote:

Hi Andrea,

please use the ML for your questions - I do not care about issues on github.

You can simply send to:

swup...@googlegroups.com

No registration required, it is fully open.

Got it!

Aha! 'papero' is a very nice hostname: sounds very italian indeed!
But I can't see your point here. In my understanding swupdate recipe does provide a defconfig via its SRC_URI. This is not a per-machine override so it should apply for any machine unless one wants to provide its own and it should do so by overriding the default (i.e. in its own bbappend). Please interrupt me if this is a wrong assumption!
Regarding your test, I don't see the log for 'devtool build swupdate', but only that for 'devtool modify swupdate'. Is 'devtool build swupdate' successfully completing in your environment?

 

> command. | ERROR: Function failed: do_configure (log file is located at
> /home/gizero/work/upstreaming/build/tmp/work/i586-poky-linux/swupdate/2016.10-r0/temp/log.do_configure.29840)
> ERROR: Task
> (/home/gizero/work/upstreaming/meta-swupdate/recipes-support/swupdate/swupdate_2016.10.bb:do_configure)
> failed with exit code '1' NOTE: Tasks Summary: Attempted 726 tasks of
> which 725 didn't need to be rerun and 1 failed. |
>
> Seems like the logic behind |devtool build| (which implies reconfiguring
> the source tree) is conflicting with how the tree is set up. I'm looking
> into it...

There is no default defconfig, and configure fails

So it should also 'bitbake swupdate' or maybe 'bitbake -f -c configure swupdate' which otherwise both run fine. Well... not exactly, I have other issues with recent QAs from oe-core, but this is a different topic I'll report about as soon as I narrow it down enough. Anyway for the purpose of this discussion, at least the configure task runs with no issues in a standard bitbake workflow. So, IMHO it's a matter of the swupdate recipe not playing nice with the devtool workflow.

 

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[Stefano Babic]

Hi Andrea,

On 13/12/2016 09:53, Andrea Galbusera wrote:
> Aha! 'papero' is a very nice hostname: sounds very italian indeed!

Like me...

> But I can't see your point here. In my understanding swupdate recipe does
> provide a defconfig via its SRC_URI. This is not a per-machine override so
> it should apply for any machine unless one wants to provide its own and it
> should do so by overriding the default (i.e. in its own bbappend). Please
> interrupt me if this is a wrong assumption!

mmhh..yes, there is a default defconfig. I am just used to overwrite it
for each project.

> Regarding your test, I don't see the log for 'devtool build swupdate', but
> only that for 'devtool modify swupdate'. Is 'devtool build swupdate'
> successfully completing in your environment?

I see the same issue - it looks like that the working directory is not
correctly set when do_configure is called. The variable S is ok and
adjusted by devtool to the correct place in workspace, .config is also
copied, but when do_configure run, the working directory is still
$BUILDDIR instead of $S.

In fact, adding a "cd ${S}" in do_configure make configure works - of
course, then it fails in do_compile for the same reason.

Best regards,
Stefano