[PATCH][libubootenv] uboot_env: Add comment for missing MAC / IP validation

[Christian Storm]

In contrast to U-Boot, libubootenv does not validate IP
and MAC addresses. The worst case would be libubootenv
storing values that U-Boot would reject on boot.
Add a comment so to be aware.

Signed-off-by: Christian Storm <christi...@siemens.com>
---
src/uboot_env.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/src/uboot_env.c b/src/uboot_env.c
index 23c15ee..8830e4f 100644
--- a/src/uboot_env.c
+++ b/src/uboot_env.c
@@ -211,6 +211,10 @@ static bool libuboot_validate_flags(struct var_entry *entry, const char *value)
break;
case TYPE_ATTR_IP:
case TYPE_ATTR_MAC:
+ /*
+ * Not validated. libubootenv does not interpret these values.
+ * In the worst case, U-Boot would reject those on boot.
+ */
break;
}
return ok_type;
--
2.55.0

[Stefano Babic]

Applied to -master, thanks !

Best regards,
Stefano

--
_______________________________________________________________________
Nabla Software Engineering GmbH
Hirschstr. 111A | 86156 Augsburg | Tel: +49 821 45592596
Geschäftsführer : Stefano Babic | HRB 40522 Augsburg
E-Mail: sba...@nabladev.com