Comment on revision r913 in swordfish-tooling

[codesite...@google.com]

renat.zubairov commented on revision r913 in project swordfish-tooling.
Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=913

Score: Neutral

General Comment:
Hi

Great, but I though we would have a workshop with brainstorming on how to
do before the actual implementation?

Renat

Respond to these comments at
http://code.google.com/p/swordfish-tooling/source/detail?r=913
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

[codesite...@google.com]

renat.zubairov commented on revision r913 in project swordfish-tooling.
Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=913

Score: Negative

General Comment:
BTW it's good that you committed the code to the repository soon, however
what is not good is that it broke the build.
I would recommend to commit code in smaller parts and make sure that will
make the code review simpler and it's also easier to follow the automated
code review reports that are generated during the build.

[codesite...@google.com]

vzhabiuk commented on revision r913 in project swordfish-tooling.

Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=913

General Comment:
Hi Renat. Unfortunately nobody told be about the brainstorming.
Nevertheless it's the initial implementation, and I'm ready to make any
changes according to the tooling team remarks.
Regarding the broken build, where can I see CC build results? Sorry for
that, will try to fix it ASAP. Probably will need support from the tooling
guys

[codesite...@google.com]

vzhabiuk commented on revision r913 in project swordfish-tooling.
Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=913

General Comment:
Want to admit, that I'm ready to obey all the rules and practices, involved
on the Tooling project

[codesite...@google.com]

renat.zubairov commented on revision r913 in project swordfish-tooling.

Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=913

Score: Neutral

General Comment:
Sure :) NP we might need to describe how tooling project works and how to
commit on it, it's a good practice which is followed by most of the
successful open source projects (not this one through). So I decided to
write it and here you go:

http://code.google.com/p/swordfish-tooling/wiki/How2Contribute

[codesite...@google.com]

vzhabiuk commented on revision r913 in project swordfish-tooling.

Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=913

General Comment:
That's cool. Thanks