Comment on revision r880 in swordfish-tooling

[codesite...@google.com]

jkind...@freenet.de commented on revision r880 in project swordfish-tooling.
Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=880

Score: Negative

General Comment:
Needs to be refactored.

Line-by-line comments:

File:
/trunk/org.eclipse.swordfish.tooling.ui/src/org/eclipse/swordfish/tooling/ui/wizards/PluginContentWsdlGenerationOperation.java
(r880)
===============================================================================

Line 176: }
-------------------------------------------------------------------------------
Who will understand this?
15 nested levels, no meaningful comments ... I'm getting dizzy ... %-|

Respond to these comments at
http://code.google.com/p/swordfish-tooling/source/detail?r=880
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

[codesite...@google.com]

renat.zubairov commented on revision r880 in project swordfish-tooling.

Details are at
http://code.google.com/p/swordfish-tooling/source/detail?r=880

Score: Negative

General Comment:
+1 We should configure automated code review tool to fail a build when it
sees it