allowableValues from Enum.values()?

[Michael Hosier]

Is it possible to provide the allowableValues value from an enum using something like MyEnum.values()? It doesn't seem possible. What I really want is to just avoid having to statically type the enum names for obvious reasons, such as refactoring breaking this.

[tony tam]

Do you mean for a model property or an operation parameter?  If a model property, this is already supported:

https://github.com/wordnik/swagger-core/blob/1.3-SNAPSHOT/modules/swagger-core/src/test/scala/converter/EnumConversionTest.scala#L17

[Michael Hosier]

Sorry, this specific instance is for a QueryParam in the ApiParam annotation. I have to declare it as 'allowableValues = "ENTRY1,ENTRY2,ENTRY3"', instead of using something like MyEnum.values() or new ArrayList<MyEnum>(MyEnum.values()), for example. Or even in this case I would say just using MyEnum.class as a value for allowableValues would be awesome, much like the response = MyClass.class feature.  Does this make sense or am I just missing something?

[tony tam]

Hi,

I believe enums are supported but only inside another object--they're explicitly ignored at the top-level for either response or input.  I have to say, I don't recall the exact reason why:

https://github.com/wordnik/swagger-core/blob/scala_2.10-1.3-RC3/modules/swagger-core/src/main/scala/com/wordnik/swagger/converter/ModelPropertyParser.scala#L30

It might be worth hacking in there and seeing if it can be supported, and offering up a pull request if so.

[Dilip Krishnan]

This is supported in swagger-springmvc. I could possibly looking at submitting a PR

-D

[Michael Hosier]

Thanks for the code snippet. I will look into that. Your offer to generate a PR is generous, it seems like this would be a good thing to add into core.