Minor changes

[Calvin Morrison]

Hi all,

I've been using svte steadily now for maybe 3 years. I think it is a
quality piece of software.

Right now there are two changes I have made that I haven't announced.

* Ability to adjust font on the fly (this is quite lazy, because fonts
don't work normally in gtk, instead they have a pango size. We iterate
over the size by +-2000 each time (but this only translates to one
point of font or less)

* Ability to always hide the tab bar. Some users are not interested in
seeing it ever, and instead of manually hiding it each time, they've
requested an option to do it. it is now a setting in the svterc called
show_tabbar

Hopefully you are all still enjoying using it like me

Calvin Morrison

[Wouter Van Rooy]

HI 

I just tried to rebuild it and for some reasons the right libraries are no longer included.

I had to do :

diff --git a/config.mk b/config.mk

index 0885e1d..03f925e 100644

--- a/config.mk

+++ b/config.mk

@@ -28,7 +28,7 @@ MANPREFIX = ${PREFIX}/share/man

 

 # includes and libs

 GTKINC=$(shell pkg-config --cflags gtk+-2.0 vte glib-2.0)

-GTKLIB=-lvte

+GTKLIB=-lvte -lgtk-x11-2.0 -lgdk-x11-2.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0

 

 INCS = -I. -I/usr/include ${GTKINC}

 LIBS = -L/usr/lib -lc ${GTKLIB}

to get it to work. I guess it has something to do with the new wayland support in gtk/gdk.

2013/11/4 Calvin Morrison <mutant...@gmail.com>

Calvin Morrison

--
You received this message because you are subscribed to the Google Groups "svte-eng" group.
To unsubscribe from this group and stop receiving emails from it, send an email to svte-eng+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Calvin Morrison]

Seems like both of the approaches are naiive. I think we should use
something like pkgconfig as we do for the GTKINC variable

diff --git a/config.mk b/config.mk
index 0885e1d..5f58aa3 100644

--- a/config.mk
+++ b/config.mk
@@ -28,7 +28,7 @@ MANPREFIX = ${PREFIX}/share/man

# includes and libs
GTKINC=$(shell pkg-config --cflags gtk+-2.0 vte glib-2.0)
-GTKLIB=-lvte

+GTKLIB=$(shell pkg-config --libs gtk+-2.0 vte glib-2.0)

INCS = -I. -I/usr/include ${GTKINC}
LIBS = -L/usr/lib -lc ${GTKLIB}

this produces a slew of librariess to link

LDFLAGS = -s -L/usr/lib -lc -lvte -lgtk-x11-2.0 -lgdk-x11-2.0
-latk-1.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lpango-1.0
-lfreetype -lfontconfig -lgio-2.0 -lgobject-2.0 -lcairo -lX11
-lglib-2.0

what do you think of that?

[Wouter Van Rooy]

Looks pretty good to me. There is also the const initialization warning. 

svte.c:132:32: warning: initialization discards ‘const’ qualifier from pointer target type [enabled by default]

   PangoFontDescription *font = vte_terminal_get_font(VTE_TERMINAL(t->vte));

2013/11/4 Calvin Morrison <mutant...@gmail.com>

[Calvin Morrison]

Yes, though not sure why

Calvin