Issue 19 in sunrise: Code review request for gcc fixes

[sun...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Review Priority-Medium

New issue 19 by trqu...@gmail.com: Code review request for gcc fixes
https://code.google.com/p/sunrise/issues/detail?id=19

I've just pushed a branch "gcc-fixes" with some changes that allow sunrise
to compile under gcc version 4.4.7 20120313 (Red Hat 4.4.7-3)

I'd like someone to look over these changes to see if they are reasonable.
A warning: although sunrise now compiles under gcc, it does not seem to run
correctly.

The changes include:
1) Deleting references to undefined attributes in a few methods. The only
way I can see how these compiled under ICC is that the Intel compiler
ignores unused methods. I checked on this by adding assert()s to any
method I changed this way. So far, none of these assert()s have been
triggered.
2) Adding some boost serialization includes that GCC apparently needs.
This may be another symptom of (1)
3) There are a couple of places where GCC got confused over type names,
template parameters, and method names.
This is where I'm not sure I got it right. Look in particular at changeset
2e3ce662555b

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings