Review D900 pull request?

[William Pietri]

Brian Martin has done a lot of work to add support for the D900. It's a large pull request: https://github.com/wpietri/sucks/pull/63

I haven't had time to do it justice, and events require me to go spend a couple of weeks with family. Could other folks take a look and give feedback?

Thanks,

William

[Brian Martin]

Has anyone had the time to review this? It seems to keep coming up with a number of users using my fork successfully.  On a related note I think #61 (https://github.com/wpietri/sucks/pull/61) should also be merged.  The combination of the two allows for Ozmo models to work properly, as found in #66 (https://github.com/wpietri/sucks/issues/66), where I merged that work into my add-fixStatus branch.

There is one more change I made in support of #66 in my add-fixStatus branch (https://github.com/bmartin5692/sucks/tree/add-fixStatus) to handle clean reports from the Ozmo model (https://github.com/bmartin5692/sucks/commit/049cc8d9e0649d8d554b5287be042e22e1201cf2).  Should I apply the same change to my D900 branch to add into #61, or submit a separate PR with just those changes?

Thanks,

Brian

[Greg Laabs]

I am planning on reviewing this PR this weekend. Somebody I work with gave me access to his account with a 900 and Ozmo 930 on the account, so I can use it to test the PR as well.

--
You received this message because you are subscribed to the Google Groups "sucks-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sucks-users...@googlegroups.com.
To post to this group, send email to sucks...@googlegroups.com.
Visit this group at https://groups.google.com/group/sucks-users.
To view this discussion on the web visit https://groups.google.com/d/msgid/sucks-users/b0ed6ba7-2f5f-4208-b48f-04fe9fd0e83d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.