With a brief glimpse, the patch looks good to me. For the imports, we do assume things based on the samples we have seen. Usually it is undocumented data formats, but even with UDDF that does actually have specification, things are somewhat different between different vendors.Is there any data stored by Shearwater in the vendor specific block? Or is the data you are still missing just not included in the export? If you can send me a sample dive exported from Shearwater, I could add it to my collection of format samples.
--
You received this message because you are subscribed to a topic in the Google Groups "Subsurface Divelog" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/subsurface-divelog/qGkPOhPhiWc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to subsurface-dive...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/subsurface-divelog/6fd2575f-3ee1-4a17-803e-fb7a266b0f77n%40googlegroups.com.
Hi Josiah.
Thanks for looking into this.
I think the reason that on Shearwater computers there is no link between entries in the list of gas mixes and entries in the list of tank sensors - Shearwater is correct in not adding links that do not exist. Also, since the list of gasmixes on Shearwater computers is dynamically ordered based on the O2 / He fractions in the gases the position of a given gas in the list will change when other gases are modified, requiring the user to manually edit the list of tank sensors every time they change the gas list if they want a certain tank sensor to stay associated with the same gas mix.
For this reason I believe that introducing a 1 : 1 mapping of gasmix list entries and tank sensor list entries that does not exist is not the correct way to go on about this. It will be better to just remove the limitation of non-linked `gasdefinition` entries not being imported if `tankdefinition` entries exist in https://github.com/subsurface/subsurface/blob/b5007bde674bd9b1100b24278250aab1790114d9/xslt/uddf.xslt#L302, and get the `gasdefnintion` entries imported as separate entities to `tankdefinition` entries, instead of incorrectly linking them into arbitrary pairs.
Ngā mihi
Michael Keller
--
You received this message because you are subscribed to the Google Groups "Subsurface Divelog" group.
To unsubscribe from this group and stop receiving emails from it, send an email to subsurface-dive...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/subsurface-divelog/9a205d27-ba32-46b9-b096-f98a63d8aae2n%40googlegroups.com.