Process for merging fixes from upstream version of libdivecomputer

[Andres Noetzli]

Hi all,

I use Subsurface to import logs from my Halcyon Symbios Handset. This works quite well, but when the unit is running in gauge mode, the corresponding logs cannot be processed. I tracked this down to a bug in libdivecomputer, which has been fixed upstream ( https://github.com/libdivecomputer/libdivecomputer/commit/69f3746ca9679adae06239ceaa7b3a94b733eaa4 ). Locally, I've compiled a version of Subsurface with the fix in place, which seems to import the logs just fine. What is the process for merging fixes/new versions from the upstream version of libdivecomputer into the Subsurface version? I'm happy to help creating PRs or whatever else is needed.

Thank you,

Andres

[Robert Helling]

Andres,

> On 7. May 2026, at 23:29, Andres Noetzli <andres....@gmail.com> wrote:
>
> I use Subsurface to import logs from my Halcyon Symbios Handset. This works quite well, but when the unit is running in gauge mode, the corresponding logs cannot be processed. I tracked this down to a bug in libdivecomputer, which has been fixed upstream ( https://github.com/libdivecomputer/libdivecomputer/commit/69f3746ca9679adae06239ceaa7b3a94b733eaa4 ). Locally, I've compiled a version of Subsurface with the fix in place, which seems to import the logs just fine. What is the process for merging fixes/new versions from the upstream version of libdivecomputer into the Subsurface version? I'm happy to help creating PRs or whatever else is needed.
>

I think you should file it a s a pull request against the Subsurface fork of libdivecomputer: https://github.com/subsurface/libdc

Best
Robert

[Carlo Spigoli]

Ok, I will do this in next days.
Thanks
Carlo

-----Messaggio originale-----
Da: subsurfac...@googlegroups.com <subsurfac...@googlegroups.com> Per conto di Robert Helling
Inviato: venerdì 8 maggio 2026 11:21
A: subsurfac...@googlegroups.com
Oggetto: Re: Process for merging fixes from upstream version of libdivecomputer

--
You received this message because you are subscribed to the Google Groups "Subsurface Divelog" group.
To unsubscribe from this group and stop receiving emails from it, send an email to subsurface-dive...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/subsurface-divelog/C4E90CE2-EDF1-4CD8-ACB6-95966DF88DB3%40atdotde.de.

[Dirk Hohndel]

It's very rare that I contradict advice from Robert, but here I have to.
Please don't.
The relationship between the upstream libdivecomputer and our libdc fork is... complicated.
One of the maintainers will handle this when they have time.

/D