Duplicate dive Sites and wrong number of dives for site

[Claude Hähni]

Hi
I recently noticed that a dive I logged where I selected a dive site I've been to before created a second dive site with the same name in the dive site overview. Also, the number of dives shown for this dive site is wrong. It shows 1 and 3 dives respectively, where it should just show 1 dive site with 2 dives logged.
This seems to be the only dive site with this problem.
Am I misunderstanding the overview? Is this a bug?
Thanks for helping me out.

[Claude Hähni]

I forgot to mention: I can reproduce this on Mac and Windows.

--
You received this message because you are subscribed to a topic in the Google Groups "Subsurface Divelog" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/subsurface-divelog/IOJ6Ifu2Dqo/unsubscribe.
To unsubscribe from this group and all its topics, send an email to subsurface-dive...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/subsurface-divelog/8ef5ec7f-e557-4940-973a-f4524cf37632n%40googlegroups.com.

[Michael Keller]

Hi Claude.

On Thursday, November 21, 2024 at 7:20:16 AM UTC+13 Claude Hähni wrote:

Hi
I recently noticed that a dive I logged where I selected a dive site I've been to before created a second dive site with the same name in the dive site overview. Also, the number of dives shown for this dive site is wrong. It shows 1 and 3 dives respectively, where it should just show 1 dive site with 2 dives logged.
This seems to be the only dive site with this problem.
Am I misunderstanding the overview? Is this a bug?

I have looked into this, and I was not able to reproduce the problem.

But one thing that is not super intuitive, and needs to be considered is how you are selecting an existing dive site.

When typing the name of an existing dive site, a drop down will appear offering multiple options: 

- the first option is to create a new dive site with the name of the existing dive site

- the second option is to pick and use the existing dive site

Hitting enter at this stage will indeed create a duplicate of the dive site - what you need to do is click on the second option.

Ngā mihi

  Michael Keller

 

[Claude Hähni]

Hi Michael,
Thank you for your reply. I definitely did use the second option.
I just tried to reproduce it. It's a little harder than I thought:
Steps:
- go to dive and delete the site info
- save
- go to dive sites: all is correct. in my case it shows 1 dive for the site
- go back to dive and set the location again
- save
- go back to dive site overview: it now shows a duplicate dive site and a total of 4 dives in my case.

Without the two "saves" I cannot reproduce it.

For better understanding, I took a short video.
Also pay attention to the dive site overview showing 3 dives for one duplicate but in the panel below only one dive is shown. So there is definitely something wrong.
You can tell when I hit save in the video when the asterisk in the title bar of the window disappears.

Thanks again for your help. 

[Claude Hähni]

Is anyone else able to reproduce this?

[Michael Keller]

Hi Claude.

On 28/11/24 23:43, Claude Hähni wrote:
> Is anyone else able to reproduce this?

Yes, I have been able to reproduce it.

I just couldn't see any obvious reason for why this is happening, or an
easy fix.

And I didn't have the time to investigate more than just the
reproduction and a quick look.


Cheers

  Michael Keller

[Claude Hähni]

Hi Michael
Thanks for looking into this and for your feedback.

This is not something critical for me. I just wanted to make sure this is documented somewhere.
Should I create a Github issue for this?

Best,
Claude

[Roney Rodrigues]

This has been happening to me for a few years now. Found a work-around: go to View Dive Sites, filter by the dive site that has a duplicate, edit the one that one has one or few dives associated to, rename the dive site, go to its dives, and change their sites to the correct one. Then delete the duplicate, unused one from the dive site list.

I know when I type the first letters of the site, use the arrow keys to highlight the correct dive site and then hit tab it happens more often. If I hit enter instead of tab it is less often. But it is a random thing, it doesn't happen all the time I repeat any given procedure. In other words, I can't make it happen intentionally.

Now I am seeing a different issue: a wrong number of dives associated to the duplicate site. See the attached pic: the second dive site indicates 58 dives, but lists only one; if I rename this second site adding a suffix, go to the main list of dives and sort by dive site indeed there is only one dive associated to the site. This one has been trickier, as I've repeated the procedure described on the first paragraph a few times and it still creates a duplicate every time.


Just wanted to add some more context.

Thank you,

Roney

[Claude Hähni]

I suspect the issue is in how the location dropdown selection is committed. It looks like the UI and backend state can get out of sync: I select an existing site, but the UI may still be in “create new dive site” mode. When saving, the code then follows the “create new site” path, but with data copied from the currently selected backend dive site, producing a duplicate.

In my XML export, the duplicate sites have UUIDs that differ by exactly 1. That looks like UUID collision avoidance logic kicking in, which strongly suggests these entries are true byte-level duplicates (same site data, different UUID).

[Claude Hähni]

I've created a PR with a proposed fix:  Fix dive-site duplication by resetting pending-site state only on actual text edits by chaehni · Pull Request #4722 · subsurface/subsurface