substrait-go library

[James Taylor]

I wanted to start a discussion around what a substrait-go library might look like. Given the success of the substrait-java library, I was thinking it'd be good to model substrait-go the same way (minus any Go idiosyncrasies). That way folks from one would be able to pick up and use the other pretty easily.

Thoughts?

[Jacques Nadeau]

Definitely makes sense to me. Matt, how does this jive with what you've been thinking/working on?

On Fri, Dec 9, 2022 at 1:17 PM James Taylor <ja...@sundeck.io> wrote:

I wanted to start a discussion around what a substrait-go library might look like. Given the success of the substrait-java library, I was thinking it'd be good to model substrait-go the same way (minus any Go idiosyncrasies). That way folks from one would be able to pick up and use the other pretty easily.

Thoughts?

--
You received this message because you are subscribed to the Google Groups "substrait" group.
To unsubscribe from this group and stop receiving emails from it, send an email to substrait+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/substrait/555c8ca7-35b2-4888-9159-7b5a35c61459n%40googlegroups.com.

[Jesus Camacho Rodriguez]

We are using a similar approach for the C# library implementation too.

Thanks,

Jesús

[Matt Topol]

I personally have a dislike of the builder pattern, but I understand it's a very common Java pattern. In addition, it's highly encouraged in Go for the "zero value" of a struct to be valid. So I've been working on what is essentially a more friendly stack of types with ToProto/FromProto functions to go back and forth from the Protobuf types because I find the way that "oneOf" types are generated to be very unintuitive to construct. 

I've put up a draft PR of what I've been working on here: https://github.com/substrait-io/substrait-go/pull/4 

I should have enough to convert it to a regular PR in the next day or so. I just want to add some examples / comments / documentation and work out one kink I was thinking about recently. Let me know what you all think!

--Matt