Version 0.9 More (Mostly Modest) Bug Fixes

5 views
Skip to first unread message

Andrew Darby

unread,
Oct 23, 2009, 1:46:55 PM10/23/09
to subjec...@googlegroups.com
Hello, all. Thanks to Gavin and Ron's diligence, more bugs have been uncovered:

1. subjects/includes/header.php was missing a closing div for the
header, so somewhere before <div id="main-body"> add another </div>.
Also, to get the floats right, add a style="clear:both;" to the
main-div.

2. in control/includes/functions.php, Gavin noticed there was a
mistake in the stripP function, and came up with a better solution.
So, replace

$text = ltrim($text, "<p>"); $text = rtrim($text, "</p>");

with

$text = preg_replace('/^<p>(.*)<\/p>$/', '$1', $text);

However, this function might not really be necessary anymore (it will
probably be removed in a future release), so you could try removing
references to it and see if your pages still work fine . . . It's
called by assets/fixed_pluslets/all_items.php,
control/records/browse.php, subjects/databases.php and
subjects/search.php.

3. On the record edit page, the "note override" box would fly out when
you clicked it, pushing the rest of the content right. Easy fix: in
control/records/record.php, find this line

$(this).parents().next().toggle('');

and remove those single quotes inside the toggle parentheses, i.e., it
should now be:

$(this).parents().next().toggle();

4. Also, the note override wasn't overriding when you inserted a
database token for that record. I.e., you have a resource like ABI
Inform, and you have a note override for your Topic guide "Best
Databases Ever." You insert the token, it should show you the
override note, not the generic note. Anyway, I needed to make some
changes to guide_functions.php--I've posted this in the files section
of the google group page; it needs to go in control/guides/

5. Finally, Ron pointed out that when you did an Insert FAQs pop-up
window from a pluslet that the Browse Collections wasn't working
right. I've posted a revised file in the files section,
fck_get_faqs.php; it needs to go in the control/guides/ folder.

This has all been updated in the zip.

Until next time . . . .

Andrew

Diane Zydlewski

unread,
Oct 23, 2009, 4:35:25 PM10/23/09
to subjec...@googlegroups.com
Hi,
Thanks for all the corrections.

The "note overide" worked correctly in Firefox, but did not work with Explorer.
When I clicked on the note override icon in Explorer, the text box did not appear. (I am using explorer 8)

Thanks,
Diane

Andrew Darby

unread,
Oct 24, 2009, 12:23:07 PM10/24/09
to subjec...@googlegroups.com
Drat. Forgot to check IE, seems there's a bug with the jQuery
toggle() and tables. Try putting the following instead in
control/records/records.php :

$('.notesplus').click(function() {

var location = $(this).parents().next();
var elem = location[0];

if (elem.style.display == 'none') {
location.show();
} else {
location.hide();
}

});

Andrew
Reply all
Reply to author
Forward
0 new messages