Implementation of Recordinality

49 views
Skip to first unread message

Jordi Montes Sanabria

unread,
Jan 21, 2016, 7:11:42 AM1/21/16
to stream-lib-user
Hello,

I am Jordi Montes, Computer Scientist from Barcelona. The last year I been studying a new algorithm called Recordinality. Recordinality counts the number of records (more generally, k-records) in a stream for giving a Cardinality estimation. It depends in the underlying permutation of the first occurrences of distinct values, so it's a very different from the other estimators. 

I discovered this library about 6 months ago and I want to contribute to it.  I have found the time for this project and I want to spend the next days doing it. I have clone the project and ran maven. I have implemented the clas Recordinality (inside cardinality) which extends from ICardinality and Serialize. I have written some tests inspired by the tests written for TestHyperloglog class.

However, I have some questions about how to integrate Recordinality in your code:
- I would need that someone check my work because I have dudes about the serialize process.

Matt Abrams

unread,
Jan 21, 2016, 2:23:21 PM1/21/16
to stream-...@googlegroups.com
Jordi -

Excellent. I'm happy that you are able to contribute your
Recordinality work to stream-lib. The best way to get feedback on
your work is to submit a pull request so we can see and comment on the
code. In case you haven't used pull requests on github before here is
a link with instructions:

https://help.github.com/articles/using-pull-requests/

Thanks,
Matt
> --
> You received this message because you are subscribed to the Google Groups
> "stream-lib-user" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to stream-lib-us...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Jordi Montes Sanabria

unread,
Jan 22, 2016, 6:37:21 AM1/22/16
to stream-lib-user
Hello Matt,

Thanks for your answer. 

I have done a pull request following the info at your link.

If you need something let me know.

Matt Abrams

unread,
Jan 22, 2016, 12:46:21 PM1/22/16
to stream-...@googlegroups.com
Jordi -

I don't see a PR against our project. Make sure you are submitting
the PR against the addthis/stream-lib project.

Thanks,
Matt

On Fri, Jan 22, 2016 at 4:37 AM, Jordi Montes Sanabria

Matt Abrams

unread,
Jan 22, 2016, 5:01:44 PM1/22/16
to stream-...@googlegroups.com
Oh, sorry I see it now. We will review.

thanks,
matt
Reply all
Reply to author
Forward
0 new messages