URGENT - bug in handling of invalid steps
Emily Greenfest-Allen
Since we were migrating to the span logic branch we also decided to
bring our code up to date and get rid of some of the legacy mess as
well as standardize naming of things such as questions, parameters,
etc. As a consequence steps involving many of our questions are invalid
as I am I trying evaluate the impact of these revisions on the stored
user data, I noticed an interesting problem.
I have a user (#346) that has a step (#1746) whose display_id is 3.
That step is the only step in a Gene strategy. The step is now invalid
because the associated query used to have two parameters and now only
has one.
It is marked as invalid in the strategy list as expected and when I open
the strategy; the pop-up appears to tell me that there is an invalid
step that needs to be revised. That's all good.
When I click on the step to revise, the correct question is displayed
and I can revise the appropriate parameter value. I click submit and
then it goes seriously down hill from there. An error box popups up on
the website, coupled with the following in the log:
392637 [ERROR] org.gusdb.wdk.controller.action.WizardAction:122 - -
[13/Dec/2011:10:59:09 -0500] java.lang.NumberFormatException: For input
string: "undefined"
This is then followed a little later by:
573677 [ERROR] org.gusdb.wdk.controller.action.ShowStrategyAction:112 -
- [13/Dec/2011:11:02:10 -0500] org.gusdb.wdk.model.WdkModelException:
The name [any_instance] does not match any filter instance of type
TranscriptRecordClasses.TranscriptRecordClass
Which was strange because I was revising a Gene Question, not a
Transcript Question! The filter does exist for the
GeneRecordClasses.GeneRecordClass.
Tracing this through, I found that there exists a step, with a step_id =
3, that is associated with a Transcript question.
There are also have 204 other steps whose display_id = 3 and are
associated with Transcript questions.
It looks to me as if there is some sort of issue with the revision of
invalid steps so that we are losing some bit of information (eg the
user_id) or using the wrong column (step_id as opposed to display_id)
during the revision of invalid steps.
I am not exactly sure where this is handled; I browsed through the
StepFactory.java, for example. So am contacting you for help. We have
a release in a week so really need to get this figured out ASAP.
Thanks,
Emily