Good to hear Rachael.
A few comments:
- You probably don't need 5k iterations--In a similar model I get autocorrelation of practically 0, perfect convergence, and typically run 4-500 iterations. How many independent draws from a distribution do you need to get an estimate of the mean? 5k draws might be useful for estimating tail quantiles, but I always take these with a grain of salt, dependent as they are on the choice of distributions. But I understand you're an economist and will probably have some seminar participant telling you to run half a million iterations with thinning of 1000 or something.
- Your priors can probably be tighter, and this will speed things up a bit. If you have a coefficient of 10 (two standard deviations on your prior), that'll basically correspond to a probability of 1 for that case. So unless you have issues with incomplete overlap, I'd use something tighter--normal(0, 1 or 2 or something). Where I mightn't do this is if you have a theoretical reason why the incomplete overlap makes sense (your cat might be an absorbing state, like default or death).
- This specification of the coefficient covariance matrix is diagonal. If you're only interested in what happens for the sites that you're measuring, then this isn't too bad (your posterior will have unmodelled covariance). In experiments I've found that explicitly modeling covariance in params doesn't make a big difference within observed levels. But if you want to generalise to new sites or model the group-level parameters directly, you'll want to specify a richer covariance structure. If you want to do this, look at the discussion from page 216 of the manual (don't use beta[m] ~ multi_normal).
- Now you can model profits for cat 1 and 3 using the same beta covariance matrix, tying the state model and profits model together. I'd model the negative of the losses so that you can use positively-constrained distributions for this.
Jim