bin/print issue?

[Michael Betancourt]

Anyone seeing an exception thrown after parameters but before generated parameters in bin/print on develop?

[Daniel Lee]

Yes. Created an issue last night.

I made some code safer and unit tested it, but the logic that fails is in the main.

I'll get that fix in tomorrow unless you get to it now.

On Oct 30, 2013 5:46 PM, "Michael Betancourt" <betan...@gmail.com> wrote:

Anyone seeing an exception thrown after parameters but before generated parameters in bin/print on develop?

--
You received this message because you are subscribed to the Google Groups "stan development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Daniel Lee]

Issue 342:
https://github.com/stan-dev/stan/issues/342

We really need some tests in place for print.

[Daniel Lee]

Fixed on branch feature/issue-342-print-crashes-with-matrix.

The fix is on Jenkins' testing queue. If anyone else wants to review it and vote for it getting in without the whole test suite, feel free to comment on the associated pull request. This change is really localized. If not, we're looking at ~2 days for it go get pushed into develop.

[Marcus Brubaker]

On Thu, Oct 31, 2013 at 12:13 PM, Daniel Lee <bea...@alum.mit.edu> wrote:

Fixed on branch feature/issue-342-print-crashes-with-matrix.

The fix is on Jenkins' testing queue. If anyone else wants to review it and vote for it getting in without the whole test suite, feel free to comment on the associated pull request. This change is really localized. If not, we're looking at ~2 days for it go get pushed into develop.

Looks like a pretty clear cut fix to me.  +1 to merge now.

[Michael Betancourt]

Looks good to me -- merge it with extreme prejudice.

[Daniel Lee]

I took that as enough yeses. Merged.