large commits?

[Bob Carpenter]

I just did a pull and got 12MB of stuff.

I took a look around rstan and the commit log and
didn't see anything.

Are there binaries getting checked in somewhere?

- Bob

[Ben Goodrich]

Binary files (at least those ending in .o and .exe) are ignored by virtue of being listed in .gitignore.

Mav merged master into rstan with 57e1d4ae4be299e40eb0d7cc448dd319967aa7ce Friday, so maybe that is what you are seeing?

Ben

[Jiqiang Guo]

I do not know.

But maybe it is time to merge rstan into master and delete rstan branch if nobody objects?

--

Jiqiang 

[Bob Carpenter]

On 7/8/12 5:33 PM, Jiqiang Guo wrote:
> But maybe it is time to merge rstan into master and delete rstan branch if nobody objects?

I don't object.

- Bob

[Ben Goodrich]

On Sunday, July 8, 2012 5:33:49 PM UTC-4, Jiqiang Guo wrote:

I do not know.

But maybe it is time to merge rstan into master and delete rstan branch if nobody objects?

For merging a branch like this into master, the basic questions are

1. Does it break anything? No.
2. Does it add any value now?  Yes.
3. Do you anticipate it being ready, perhaps with some more work, for the next Stan release? Yes.

So, I would say it could have been merged as soon as it became possible to install RStan.

Ben
 

[Jiqiang Guo]

That is a good way of thinking. I took that as a yes, merged rstan into master, and deleted rstan on google.

--

Jiqiang