FAIL

[Ben Goodrich]

Can we establish a convention to not use test names that include the string "fail"? That way you can grep the test log without getting false positives like

goodrich@CYBERPOWERPC:/opt/stan$ grep -F -i "fail" /tmp/clang++.log
[ RUN      ] AgradMatrix.assign_failure
[       OK ] AgradMatrix.assign_failure (0 ms)

I just renamed that test assign_error in f82a647.

Ben

[Daniel Lee]

Isn't "error" just as bad? If you're looking for failed tests, can't you search for "failed"? Or even "FAILED"?

I don't mind if we have a convention, but since there isn't an substantive reason for it, I feel like I'm going to forget and you'll have the problem in the future.

Daniel

Ben

--
You received this message because you are subscribed to the Google Groups "stan development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Ben Goodrich]

Since all the tests were passing at the time, I couldn't remember all the variations of the stem word fail that appear when there are failures. Is it just case-insensitive failed? I changed that test name to assign_error because I didn't think anyone would grep for "error" since that would produce all sorts of hits on ErrorHandling and so forth.

Ben

[Daniel Lee]

It looks like:

[ RUN      ] McmcChains_New.blocker_quantile
cache_size: 501
cache_size: 501
cache_size: 501
cache_size: 501
cache_size: 501
src/test/mcmc/chains_test.cpp:454: Failure
Value of: chains.quantile(0,index,0.5)
  Actual: 0.0063817799
Expected: 0.00629350
Which is: 0.0062934998
[  FAILED  ] McmcChains_New.blocker_quantile (87 ms)
[----------] 13 tests from McmcChains_New (5282 ms total)

[----------] Global test environment tear-down
[==========] 13 tests from 1 test case ran. (5282 ms total)
[  PASSED  ] 12 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] McmcChains_New.blocker_quantile

It's fine if you want to continue to rename them. I'll try to remember to avoid fail, but just in case I do, search for case-sensitive "FAILED".

Daniel