unused variable in beta.hpp

4 views
Skip to first unread message

Ben Goodrich

unread,
Aug 21, 2012, 1:03:51 PM8/21/12
to stan...@googlegroups.com
git grep -n log_beta_AB src/

shows that

src/stan/prob/distributions/univariate/continuous/beta.hpp:123: const double log_beta_AB = log(boost::math::beta(alpha_dbl, beta_dbl));

is not used elsewhere in that function. Can we get rid of log_beta_AB or was it supposed to be used in the gradient calculation somewhere?

Ben

Bob Carpenter

unread,
Aug 21, 2012, 1:35:30 PM8/21/12
to stan...@googlegroups.com
The doc implies it's for gradients, but
it's clearly not used anywhere, so by all
means nuke it.

I think what happened is that we broke the
beta function down into its component gamma
functions to separate what's needed for normalization
where.

- Bob
Reply all
Reply to author
Forward
0 new messages