Bug in changes to model methods

2 views
Skip to first unread message

Michael Betancourt

unread,
May 15, 2013, 10:48:25 AM5/15/13
to stan...@googlegroups.com
Bob, in (un)constrained_param_names the parser doesn't separate elements of vectors/matrices, so you just get a single element with all of the names concatenated together.

Bob Carpenter

unread,
May 15, 2013, 11:18:55 AM5/15/13
to stan...@googlegroups.com


On 5/15/13 10:48 AM, Michael Betancourt wrote:
> Bob, in (un)constrained_param_names the parser doesn't separate elements of vectors/matrices, so you just get a single
> element with all of the names concatenated together.

I'm right now in process hell and don't know which way's up.
Feel free to fix it locally or let me know what branch you're
on and I can do something there if I have permissions.

- Bob

Michael Betancourt

unread,
May 15, 2013, 11:48:52 AM5/15/13
to stan...@googlegroups.com
I've been developing on the same fork I start last night, so you wouldn't be able to modify my code directly.  But you can make the change in the stan-dev/stan/mcmc_writer branch and I can track that.  I'd try to fix it myself, but I haven't spend any time with the parser at all.




- Bob

--
You received this message because you are subscribed to the Google Groups "stan development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



Daniel Lee

unread,
May 15, 2013, 12:00:38 PM5/15/13
to stan...@googlegroups.com
Can't you give Bob commit access to your branch? If not, he can fork that and submit a pull request to you. 
To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+u...@googlegroups.com.

Michael Betancourt

unread,
May 15, 2013, 12:14:38 PM5/15/13
to stan...@googlegroups.com
Yeah, but the fork should track changes to the stan repo, right?  So it's just as easy to modify the branch in the stan repo directly (I'd be coding there, if it weren't for the momentum to keep using the current fork).

Ben Goodrich

unread,
May 15, 2013, 12:23:23 PM5/15/13
to stan...@googlegroups.com
Maybe just post the patch (git diff SHA SHA~1 > /tmp/Mike.diff) that fixes it and Bob or Daniel can git apply it to master?

Ben


On Wednesday, May 15, 2013 12:14:38 PM UTC-4, Michael Betancourt wrote:
Yeah, but the fork should track changes to the stan repo, right?  So it's just as easy to modify the branch in the stan repo directly (I'd be coding there, if it weren't for the momentum to keep using the current fork).
On Wed, May 15, 2013 at 5:00 PM, Daniel Lee <bea...@alum.mit.edu> wrote:
Can't you give Bob commit access to your branch? If not, he can fork that and submit a pull request to you. 


On May 15, 2013, at 11:48 AM, Michael Betancourt <betan...@gmail.com> wrote:

I've been developing on the same fork I start last night, so you wouldn't be able to modify my code directly.  But you can make the change in the stan-dev/stan/mcmc_writer branch and I can track that.  I'd try to fix it myself, but I haven't spend any time with the parser at all.
On Wed, May 15, 2013 at 4:18 PM, Bob Carpenter <ca...@alias-i.com> wrote:


On 5/15/13 10:48 AM, Michael Betancourt wrote:
Bob, in (un)constrained_param_names the parser doesn't separate elements of vectors/matrices, so you just get a single
element with all of the names concatenated together.

I'm right now in process hell and don't know which way's up.
Feel free to fix it locally or let me know what branch you're
on and I can do something there if I have permissions.


- Bob

--
You received this message because you are subscribed to the Google Groups "stan development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


--
You received this message because you are subscribed to the Google Groups "stan development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply all
Reply to author
Forward
0 new messages