[VOTE] Release sqlline-1.9.0 (release candidate 1)

13 views
Skip to first unread message

Julian Hyde

unread,
Oct 14, 2019, 2:06:38 AM10/14/19
to sqlline-dev
I have created a build for SQLLine 1.9.0, release candidate 1.
Since release candidate 0, we have fixed bugs
revise the previously committed fix for
https://github.com/julianhyde/sqlline/issues/354. 

Thanks to everyone who have contributed to this release. You can read
the release notes here:
https://github.com/julianhyde/sqlline/blob/branch-1.9/HISTORY.md

The commit to be voted upon:
https://github.com/julianhyde/sqlline/commit/b7f67a52498cbea29ea7e699a4f45394ebd83238

Its hash is b7f67a52498cbea29ea7e699a4f45394ebd83238

A staged Maven repository is available for review at:
https://oss.sonatype.org/content/repositories/sqlline-1013/

Please vote on releasing this package as SQLLine 1.9.0. The vote is
open for the next 72 hours and passes if a majority of at least three
+1 votes are cast by committers. Votes from people who are not
committers are also most welcome.

[ ] +1 Release this package as SQLLine 1.9.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because…

Here is my vote: +1 (binding)

Julian

Sergey Nuyanzin

unread,
Oct 14, 2019, 4:39:21 PM10/14/19
to Julian Hyde, sqlline-dev
Thanks for new build and starting voting, Julian !

I checked signatures and different cases related to release changes.
it works fine

the only thing I found : on Windows there are 2 tests failing https://github.com/julianhyde/sqlline/issues/357
At the same time sqlline still works as expected

--
You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/C7A91628-CFA5-4B04-A605-B93BD0306995%40apache.org.


--
Best regards,
Sergey

Julian Hyde

unread,
Oct 15, 2019, 3:07:03 PM10/15/19
to sqlline-dev
Thanks Sergey. I don’t think the windows test failure is a show-stopper. We could fix it right after release. I see you provided a PR.

Sergey Nuyanzin

unread,
Oct 16, 2019, 2:45:02 AM10/16/19
to Julian Hyde, sqlline-dev
Yes, I agree that it is not a show-stopper
+1 from my side

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/FB54C96E-C1CD-4436-843E-F27C824B4499%40apache.org.


--
Best regards,
Sergey

Arina Ielchiieva

unread,
Oct 16, 2019, 8:02:36 AM10/16/19
to sqlline-dev
Build from source (saw problem mentioned by Sergey with unit tests on Windows).
Checked with Apache Drill:
1. new properties usage: connectInteractionMode, showLineNumbers;
2. verified that issue #305 is fixed (submitting password with space and escaping).
3. random checks.

+1

Kind regards,
Arina

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBjoWRdpExk9WbBi3%3DNe1kWivMUbWq0UdEAd99b%3DBhiMCg%40mail.gmail.com.

Julian Hyde

unread,
Oct 17, 2019, 5:55:33 AM10/17/19
to sqlline-dev
With 3 binding +1 votes (Julian, Sergey, Arina), the vote passes.

I declare SQLLine 1.9.0 released!

Thanks to all who voted, and thanks to our contributors.

Julian
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev+unsubscribe@googlegroups.com.


--
Best regards,
Sergey

--
You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev+unsubscribe@googlegroups.com.


--
Best regards,
Sergey

--
You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages