[VOTE] Release sqlline-1.7.0 (release candidate 1)

[Julian Hyde]

Hi all,

I have created a build for SQLLine 1.7.0, release candidate 1.

It has the same contents as RC 0, but:
* adds a test for SQLLINE-276;
* corrects attribution for SQLLINE-239 and SQLLINE-273;
* fixes SQLLINE-281.

Thanks to everyone who has contributed to this release. You can read
the release notes here:
https://github.com/julianhyde/sqlline/blob/branch-1.7/HISTORY.md

The commit to be voted upon:
https://github.com/julianhyde/sqlline/commit/2752f8197759a349d5a747bbe48e889b878228d3

Its hash is 2752f8197759a349d5a747bbe48e889b878228d3

A staged Maven repository is available for review at:
https://oss.sonatype.org/content/repositories/sqlline-1010/

Please vote on releasing this package as SQLLine 1.7.0. The vote is
open for the next 72 hours (i.e. until 3pm Pacific on Monday) and
passes if a majority of at least three +1 votes are cast by
committers. Votes from people who are not committers are also most
welcome.

[ ] +1 Release this package as SQLLine 1.7.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because…

Here is my vote: +1 (binding)

[Masayuki Takahashi]

- Ran tests
- Win10, jdk1.8.0_181 - ok
- Docker openjdk8 - ok
- Docker adoptopenjdk11 - ok
- Checked README and README.md - ok
- Checked manual.txt and manual.xml - ok

+1 (non-binding)

Thanks Julian!

2019年3月24日(日) 8:46 Julian Hyde <jh...@apache.org>:

> --
> You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
> To post to this group, send email to sqlli...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeER83mfVbGqaAvA3UOxmQW5%2BuPp0SsTFGV_R4F2k8TN61g%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--
Masayuki Takahashi

[Arina Yelchiyeva]

- Built from source and run unit tests on MacOS with JDK8
- Used build with Apache Drill:
a. Checked that !script functionality was fixed
b. Checked custom prompt functionality
c. Checked properties validation
d. Other random checks

+1 (binding)

Kind regards,
Arina

> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CA%2Bz6ocSyZ_e5j7MX3ed3jzW5P_OvowqdQJKjJE7BnWm1W6GMUg%40mail.gmail.com.

[Julian Hyde]

Oops, one minor mistake. The line that reads

> The vote is
> open for the next 72 hours (i.e. until 3pm Pacific on Monday)

should instead read

> The vote is
> open for the next 72 hours (i.e. until 5pm Pacific on Tuesday)

It isn’t a material change, so the vote continues.

Julian

[Vova Vysotskyi]

- Built and run unit tests on Linux with JDK8

- Connected to several databases and submitted queries

- Checked that #276 is fixed

+1 (non-binding) 

понеділок, 25 березня 2019 р. 00:14:21 UTC+2 користувач Julian Hyde написав:

[Sergey Nuyanzin]

- built and ran tests (fedora29, jdk 1.8) - ok

- checked HISTORY.md - ok

- checked checksum and signatures - ok

- checked working with calcite 1.18.0, 1.19.0 - ok

- random checks - ok

+1 (binding)

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/a59ea234-d69c-4003-9118-43933578b587%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Best regards,
Sergey

[Julian Hyde]

With 3 binding +1 votes (Julian, Arina, Sergey), and 2 non-binding +1
(Masayuki, Vova), the vote passes.

I declare SQLLine 1.7 released!

Thanks to all who voted, and thanks to our contributors.

Julian

[Julian Hyde]

Release notes are here:
https://github.com/julianhyde/sqlline/blob/master/HISTORY.md#170-2019-03-27

I added a demo of the new "promptScript" property:
https://asciinema.org/a/EGUcLB1y4RBBdf1rxKsErmOoM?speed=2.5&theme=solarized-dark&cols=78&rows=18

Julian

> --
> You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
> To post to this group, send email to sqlli...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeESTmK%2BQEJzoMbS_vOBW%2BiBJ0ddAUG-3GHYADVxvgfO5kg%40mail.gmail.com.

[Arina Ielchiieva]

Build from source (saw problem mentioned by Sergey with unit tests on Windows).

Checked with Apache Drill:

1. new properties usage: connectInteractionMode, showLineNumbers;

2. verified that issue #305 is fixed (submitting password with space and escaping).

3. random checks.

+1

Kind regards,

Arina

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBh9CVy8TcaDS7oTVuHnfbtcneEhPYznNDZinZj-%3Dqoc0A%40mail.gmail.com.

[Arina Ielchiieva]

Please disregard, wrong email thread.