[VOTE] Release sqlline-1.9.0 (release candidate 0)

[Julian Hyde]

I have created a build for SQLLine 1.9.0, release candidate 0.
(Actually Sergey did most of the work preparing the release; I just
uploaded it to sonatype.org and sent out this email.)

Thanks to everyone who have contributed to this release. You can read
the release notes here:
https://github.com/julianhyde/sqlline/blob/branch-1.9/HISTORY.md

The commit to be voted upon:
https://github.com/julianhyde/sqlline/commit/9eec023ab9796814197bcabaaf555eda0811b496

Its hash is 9eec023ab9796814197bcabaaf555eda0811b496

A staged Maven repository is available for review at:
https://oss.sonatype.org/content/repositories/sqlline-1012/

Please vote on releasing this package as SQLLine 1.9.0. The vote is
open for the next 72 hours and passes if a majority of at least three
+1 votes are cast by committers. Votes from people who are not
committers are also most welcome.

[ ] +1 Release this package as SQLLine 1.9.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because…

Here is my vote: +1 (binding)

Julian

[Sergey Nuyanzin]

Thanks for uploading to sonatype.org and starting the vote, Julian!

I checked checksums, compilation on Linux and Windows and different stuff regarding bugs/features from the release

currently it looks good to me

+1 (binding)

--
You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeET5jx0e2gCS6VGJg6Tq%3D8O8Z7MSGWeGvPjxLA8aOCvYYw%40mail.gmail.com.

--

Best regards,
Sergey

[Masayuki Takahashi]

- Ran tests
- Win10, jdk1.8.0_181 - ok
- Docker openjdk8 - ok
- Docker openjdk12 - ok
- Checked README and README.md - ok
- Checked manual.txt - ok

+1 (non-binding)

Thanks Julian!

2019年9月23日(月) 12:49 Julian Hyde <jh...@apache.org>:

> --
> You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeET5jx0e2gCS6VGJg6Tq%3D8O8Z7MSGWeGvPjxLA8aOCvYYw%40mail.gmail.com.



--

Masayuki Takahashi

[Arina Yelchiyeva]

After upgrade, Drill unable to connect to SqlLine, shows the following error:

Usage: connect [-no-np] [-p property value]* <url> [username] [password] [driver]

Which changes have been done in terms of connection? Are they necessary?

Kind regards,

Arina

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CA%2Bz6ocQ6qEwfdWxKpsYpQ3nt%2BE4isYg9UO_bxrHCvdg_y5tnVg%40mail.gmail.com.

[Sergey Nuyanzin]

Arina thank you for highlighting.

Could you a bit elaborate please and tell what is the connection string you are using?

I tried to use different connection strings including the one mentioned at https://github.com/julianhyde/sqlline/issues/305 and I can't get the same issue (however I tried to connect to calcite and different rdbms as I do not have Drill installed)

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/A5856758-C9F2-4BFE-8F36-A874D87E1A56%40gmail.com.

--

Best regards,
Sergey

[Sergey Nuyanzin]

About changes in terms of connection.

I guess it came with https://github.com/julianhyde/sqlline/issues/326

--

Best regards,
Sergey

[Arina Ielchiieva]

Hi Sergey,

thanks for the pointers, they helped a lot.

To connect to Drill in embedded mode, for example, the following connection string is used:

sqlline -u "jdbc:drill:zk=local"

This command is embedded into drill-embedded.sh script so users simply call this script.

If user wants to enter username he is calling ./drill-embedded -n user1

If -p parameter was not passed, user is asked for the password interactively.

After new changes, standard script fails with Usage:  connect [-no-np] [-p property value]* <url> [username] [password] [driver]

If we add -no-np flag to the standard script, issue is resolved but user won't be able to connect interactively anymore.

We can't force user to provide -no-op flag when connecting to Drill, neither we can't hard-code -no-op in our script since this would prevent users from connection in the interactive mode.

Looks like new changes are breaking back-ward compatibility. Is there a way to leave previous behavior and switch to the new one if needed?

Kind regards,

Arina

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBgY%2B1e7ipXqjwsUs2Dm%2Bv6K2BuvrmOubPzheFb06gDXww%40mail.gmail.com.

[Julian Hyde]

I think this is a show-stopper. Canceling the vote.

I have logged https://github.com/julianhyde/sqlline/issues/352. Please continue discussion there, and add more details if you have them.

Thanks to all who tested this release and voted. Hopefully we’ll have better luck next time.

Julian

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAC1ju52FJ-Lu7BtUqtJDgu3HnsCwKxjSDiAvN5M3ihZbWk_wPw%40mail.gmail.com.

[Julian Hyde]

Oops, forgot to add “[CANCEL]” to the subject line. The vote is canceled.

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/F4671AD1-D2A8-4592-AD9F-C9D57DDC1BBC%40apache.org.