[VOTE] Release sqlline-1.7.0 (release candidate 0)

[Julian Hyde]

Hi all,

I have created a build for SQLLine 1.7.0, release candidate 0.

Thanks to everyone who has contributed to this release. You can read
the release notes here:
https://github.com/julianhyde/sqlline/blob/branch-1.7/HISTORY.md

The commit to be voted upon:
https://github.com/julianhyde/sqlline/commit/e2bbad6770dfb00431e6abce8233efce4c55064f

Its hash is e2bbad6770dfb00431e6abce8233efce4c55064f

A staged Maven repository is available for review at:
https://oss.sonatype.org/content/repositories/sqlline-1009/

Please vote on releasing this package as SQLLine 1.7.0. The vote is
open for the next 72 hours (i.e. until 3pm Pacific on Monday) and
passes if a majority of at least three +1 votes are cast by
committers. Votes from people who are not committers are also most
welcome.

[ ] +1 Release this package as SQLLine 1.7.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because…

Here is my vote: +1 (binding)

Julian

[Masayuki Takahashi]

- Ran tests (win10, openjdk8, adoptopenjdk11) - ok
- Checked README and README.md - ok
- Checked manual.txt and manual.xml - ok

+1 (non-binding)

Thanks Julian!

2019年3月23日(土) 6:32 Julian Hyde <jh...@apache.org>:

> --
> You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
> To post to this group, send email to sqlli...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAMCtmeKGcxTx0qEXSa%2Bce2%2BMOZqxdYGuxXLgSh76PpAt_wArJw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--
高橋 真之

[Sergey Nuyanzin]

there are some findings (in tests and release notes, so it does not affect the functionality):

- Tempdir is not removed after build finished (https://github.com/julianhyde/sqlline/issues/281 )

- for https://github.com/julianhyde/sqlline/blob/branch-1.7/HISTORY.md

  I added Swaroopa Kadam for sqlline-239 at https://github.com/julianhyde/sqlline/pull/283

as both of them are easy fix it makes sense to fix them before release

the others look ok

- checked compilation with tests (fedora29, jdk1.8) - ok

- checked simple queries (highlighting, completion, prompting) - ok

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CA%2Bz6ocRjNrn03pW5qejfaP1ooBhxH9YiRk4d5UAYjm3avfBvWg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Best regards,
Sergey

[Julian Hyde]

Sergey,

I agree, those are worth fixing before the release. It was a mistake to not give Swaroopa credit. I’ll make an RC1 in a day or two. 

Others,

Please continue to test RC0. If we find problems now, they can still be fixed before the release. 

Julian 

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBjD_za7p%2BdpP5TW-YBHHJP6%3DSjfDrLc0_%2B%2BRLb%2Bz%2BsTQg%40mail.gmail.com.

[Julian Hyde]

Canceling vote for RC0 due to the issues Sergei raised. I will start an RC1 vote shortly.