Towards SQLLine release 1.12.0

[Julian Hyde]

Charles has pointed out that #444 is a show-stopper - people can't use
SQLLine on Apple M1. I think we should make a release in the next few
days.

Sergey, how would you like to divide up work? I'm happy to be release
manager if you can get review and merge some PRs. Or you could be
release manager; you could make the release commit, including writing
the release notes, although I think I'll have to make the push to
maven central.

When we have an RC, I'd be grateful if a few other people can test it and vote.

Julian

[Charles Givre]

I'm happy to help test as well. 

Best,

-- C

Charles Givre

Founder, CEO DataDistillr

Email:

cha...@datadistillr.com

Phone:

+ 443-762-3286

Book a Meeting 30 min • 60 min

LinkedIn @cgivre

GitHub @cgivre

--
You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeESEon90RQdgMOX0Um1BLmyMmzNjkAabvY40%3DONEhMgzDA%40mail.gmail.com.

[Sergey Nuyanzin]

From my side I'm happy to review and merge PRs
also i can prepare release notes and a release commit.

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/D50A4412-2156-47A3-B47E-4E024E735CC6%40datadistillr.com.

--

Best regards,
Sergey

[Julian Hyde]

Thanks, Sergey.

I think you could also send the “[VOTE]” email. Unlike ASF, we don’t vote on source or binary artifacts, just on a GitHub commit, so you can start and finish the vote before I push any artifacts to Sonatype/Maven Central. 

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBgG_J6284THovOegSzndXq0Pr9EM7zXeA7YsK5ceQpWEA%40mail.gmail.com.

[Sergey Nuyanzin]

yes, sure, you are right
I will do it

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeESyb2%3Dnyxis2wxHqLTXVxC9fKoPwSZhc5ro3CYo25024g%40mail.gmail.com.

--

Best regards,
Sergey

[Julian Hyde]

Sergey, How's the release going? Is there anything I can do to help?

[Sergey Nuyanzin]

Hi Julian

I merged almost all PRs

this one is questionable about jbang  https://github.com/julianhyde/sqlline/pull/430

Do you think it makes sense to have it sqlline?

Meanwhile I have a prepared release notes and will go to commit it to branch to review

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeETXjyxMdKBYXWtC4gVfL8GXNbfvoakdhGdZDuwXrq14Ag%40mail.gmail.com.

--

Best regards,
Sergey

[julia...@gmail.com]

I’d skip the jbang PR. I’ve not heard of jbang. If it’s not a major platform, we’re adding complexity if we support it.  

By the way, I noticed there is a Debian package based on a very old version of SQLLine. If we want to make SQLLine easier to install the Debian package is where we should spend our cycles, rather than jbang. It would be great if people could just type ‘sudo apt install sqlline’. 

On Nov 2, 2021, at 11:38 PM, Sergey Nuyanzin <snuy...@gmail.com> wrote:



To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBi42633NjEwg7sXzOc795bng5Zj8QKX3n6kvh_5P0iD6Q%40mail.gmail.com.

[Sergey Nuyanzin]

Thanks James, Julian

I've logged that issue at https://github.com/julianhyde/sqlline/issues/457

regarding SQLLine release 1.12.0

I've done with release commit to sqlline-1.12.0 branch

I will start voting based on GitHub commit shortly

On Wed, Nov 3, 2021 at 7:54 AM James Turton <dz...@apache.org> wrote:

Hi Sergey and Julian

I already do a small bit of Debian package maintenance in the Debian Science team.  I'm now overdue to return to that and do some updates.  If you'd like I can contact the Debian Java team when I do, and see if I can upload an updated sqlline package...

James Turton
Apache Drill committer

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/B958E88B-EE8D-4733-B402-90AE7612C2EA%40gmail.com.

--

Best regards,
Sergey

[Sergey Nuyanzin]

Julian, could you please clarify a question

should I start voting based on code in branch (branch-1.12)

or first commit to master and then start voting based on code in master?

On Wed, Nov 3, 2021 at 9:31 AM Julian Hyde <jhyde....@gmail.com> wrote:

James,

That would be excellent. A Debian package will have a huge impact. Thanks for your help. 

Julian

--

Best regards,
Sergey

[Julian Hyde]

Branch or no branch - either is fine.

In the past we've released from main branch (former master), paused commits to main during the release, and created a branch and tag after the release. In future, perhaps we can stop making the branches, but let's not change the process right now.

[Sergey Nuyanzin]

ok ,thanks for clarification

I've started vote thread

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeESC4o8tJq97AwVeHj23MAkHTJqeuU2Tzs2QKZgUPEpYSQ%40mail.gmail.com.

--

Best regards,
Sergey