Towards SQLLine release 1.10.0

6 views
Skip to first unread message

Julian Hyde

unread,
Feb 17, 2021, 9:06:31 PM2/17/21
to sqlline-dev
I am close to making a release candidate for 1.10.0. I logged a case
for 1.10 [1], merged Sergey's PR for scriptEngine [2], and wrote some
release notes. Build and tests run successfully on JDK 8, 11, 13, 15
on Linux.

The only problem I have found is that tests hang on Windows. I was
able to get a successful build only by disabling CompletionTest and
SqlLineArgsTest, with the following patch:

diff --git a/pom.xml b/pom.xml
index 5dc18a1..7976e7b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -272,6 +272,10 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>
+ <excludes>
+ <exclude>CompletionTest.java</exclude>
+ <exclude>SqlLineArgsTest.java</exclude>
+ </excludes>
<useManifestOnlyJar>false</useManifestOnlyJar>
<systemPropertyVariables>
<!-- Run tests in Turkish to make sure that they don't depend on

Can someone please look into those tests?

Julian

[1] https://github.com/julianhyde/sqlline/issues/424

[2] https://github.com/julianhyde/sqlline/pull/422

Sergey Nuyanzin

unread,
Feb 18, 2021, 3:07:58 PM2/18/21
to Julian Hyde, sqlline-dev
Julian, thank you for starting 1.10.0 activities

I don't have Windows however I tried to reproduce this on Appveyor with Windows Server 2019 [1]
All tests without exclusions for JDKs 8, 11, 12, 13, 14, 15 are passed

--
You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAMCtmeJ-h%2B4HWEWUtv8c%2Ba0QaeNMxBpTQyPE_DmP3cYwsk%3DGxA%40mail.gmail.com.


--
Best regards,
Sergey

Julian Hyde

unread,
Feb 18, 2021, 4:21:10 PM2/18/21
to Sergey Nuyanzin, Julian Hyde, sqlline-dev
Thanks for checking, Sergey. I'll assume that there's something wrong
with my environment. (I'm running Windows 12 in a VM, using cygwin,
because I hate Windows, and only use it when I am trying to verify
something.)

I'm going to create an RC and start a vote.

Julian
> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBgQ0TzHoL%2BZtf_E7JmSvtcWw6D2Tn%3D9M7ca66ndqLgS_A%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages