Please vote on releasing this package as SQLLine 1.6.0. The vote is open for the next 72 hours (i.e. until 4pm Pacific on Monday) and passes if a majority of at least three +1 votes are cast by committers. Votes from people who are not committers are also most welcome.
[ ] +1 Release this package as SQLLine 1.6.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because…
Here is my vote: +1 (binding)
Julian
Sergey Nuyanzin
unread,
Nov 24, 2018, 6:27:34 AM11/24/18
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sqlline-dev
+1
Checked checksums Compiled under Windows 2016 (jdk8, 9, 10) and Fedora 29 Compiled Apache Calcite with sqlline 1.6.0 Tested with Apache Calcite, H2 Checked default value of maxColumnWidth and presence of sqlline.SqlLineOpts#getMaxWidth Tested highlighting, dynamic prompts, multiline editing, line continuation, emacs/vi modes, rerun command, simple queries
Arina Yelchiyeva
unread,
Nov 24, 2018, 10:41:58 AM11/24/18
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sqlline-dev
+1
Built from source with unit tests.
Tested with Apache Drill.
Checked multiline support, set / reset, a couple of color schemes.
Checked maxColumnWidth.
Kind regards,
Arina
Julian Hyde
unread,
Nov 26, 2018, 10:30:54 PM11/26/18
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sqlline-dev
With 3 +1 votes (Arina, Julian, Sergey) and no 0 or -1 votes, the vote passes.
I declare sqlline-1.6.0 released!
Thank you, Sergey, for the huge contribution you made this this release.