[VOTE] Release sqlline-1.8.0 (release candidate 0)

[Julian Hyde]

Hi all,

I have created a build for SQLLine 1.8.0, release candidate 0.

Thanks to everyone who have contributed to this release. You can read
the release notes here:
https://github.com/julianhyde/sqlline/blob/branch-1.8/HISTORY.md

The commit to be voted upon:
https://github.com/julianhyde/sqlline/commit/ac1f18537a2649dacf599c83b5c7f03341ba4221

Its hash is ac1f18537a2649dacf599c83b5c7f03341ba4221

A staged Maven repository is available for review at:
https://oss.sonatype.org/content/repositories/sqlline-1011/

Please vote on releasing this package as SQLLine 1.8.0. The vote is
open for the next 72 hours and passes if a majority of at least two +1
votes are cast by committers. Votes from people who are not committers
are also most welcome.

[ ] +1 Release this package as SQLLine 1.8.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because…

Here is my vote: +1 (binding)

Julian

[Sergey Nuyanzin]

Thank you for RC and starting the vote

+1 (binding)

   checked hashes

   checked compilation on Ubuntu 19.04, Fedora 30

   checked simple queries and random commands

There are only two small things regarding HISTORY.md which I would like to mention

1) I think Volodymyr Vysotskyi should be mentioned at [SQLLINE-292] Ctrl-C causes SQLLine to quit, but should just cancel current query

2) About "more powerful !set outputformat command" in history. To be more precise the command !set outputformat was not changed but the command !outputformat has been indeed made more powerful

--
You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
To post to this group, send email to sqlli...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeESL3kN-Za33vgNsqbQLKzJC1P4ORm8FoU3Nufqj3nuQ6Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

Best regards,
Sergey

[Julian Hyde]

Re. 1 + 2. Thanks. As these are not errors in the code, I have fixed these on the master branch, and they will appear on the site after the release.

https://github.com/julianhyde/sqlline/commit/ffb5c6de098c086dc5228bffc3b2d4d56cf87e15

Julian

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAKQOUBhbbkgZoW%2BxuAUDFo20kVxXRCY2iUxndsiVa5H6n2GtBA%40mail.gmail.com.

[Julian Hyde]

A reminder to verify this release and vote. This vote ends tomorrow,
and I may end it a few hours early.

Votes from non-committers are most welcome; if there are issues that
affect your downstream project, we take them seriously.

Julian

[Andrew Pilloud]

+1 Manually tested with BeamSQL.

To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeESyaj%3Dmry0P%3DkPMONj%3DwFS%2B2b-V%3DM_px_WNzsoBy9wiyg%40mail.gmail.com.

[Masayuki Takahashi]

- Ran tests
- Win10, jdk1.8.0_181 - ok
- Docker openjdk8 - ok
- Docker openjdk12 - ok
- Checked README and README.md - ok
- Checked manual.xml - ok

+1 (non-binding)

Thanks Julian!

2019年5月28日(火) 10:24 Julian Hyde <jh...@apache.org>:

> --
> You received this message because you are subscribed to the Google Groups "sqlline-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to sqlline-dev...@googlegroups.com.
> To post to this group, send email to sqlli...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CAPSgeESL3kN-Za33vgNsqbQLKzJC1P4ORm8FoU3Nufqj3nuQ6Q%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--

Masayuki Takahashi

[Julian Hyde]

With 2 binding +1 votes (Julian, Sergey), and 2 non-binding +1 votes
(Andrew, Masayuki), the vote passes.

I declare SQLLine 1.8 released!

Thanks to all who voted, and thanks to our contributors.

Julian

> To view this discussion on the web visit https://groups.google.com/d/msgid/sqlline-dev/CA%2Bz6ocRK6-hKF7hFEs4O-b_7LLqZ104L995bfpszboJVJdbmLA%40mail.gmail.com.