Probable bug in Internal.java, concerning archs

[plo...@gmail.com]

Hi guys,

I'm not sure where to report issues (https://code.google.com/p/sqlite4java/issues/list looks pretty calm...)

I suspect a typo in the code in Internal.java, line 166 (https://code.google.com/p/sqlite4java/source/browse/trunk/java/com/almworks/sqlite4java/Internal.java#166) :

    } else if (arch.equals("x86")) {
      r.add(base + "-i386");
    } else if (arch.equals("i386")) {
      r.add(base + "-x86");

Is there any reason to mix arch like that, or is that a copy/paste typo?

Thanks,

[Igor Sereda]

Hi!

Thanks for checking out the code :) There's no bug here. We assume "x86" and "i386" suffixes to be synonyms for the same architecture (at least among the modern ones), so when arch is x86 we're also checking if there's a binary with -i386 suffix, and vice versa.

Kind regards,

Igor

[plo...@gmail.com]

Thanks Igor for your quick answer!

But now, I'm puzzled because of this revision: https://code.google.com/p/sqlite4java/source/diff?spec=svn398&r=398&format=side&path=/trunk/java/com/almworks/sqlite4java/Internal.java

Who is right? :D

[Igor Sereda]

:) 

This revision was an error (a too quick reaction to your question without much thinking), and it will be reverted.

Cheers,

Igor

--
You received this message because you are subscribed to the Google Groups "sqlite4java" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sqlite4java...@googlegroups.com.
To post to this group, send email to sqlit...@googlegroups.com.
Visit this group at http://groups.google.com/group/sqlite4java.
For more options, visit https://groups.google.com/d/optout.