Re: [sqlite3-ruby] Bug in execute_batch ?

[Aaron Patterson]

On Sat, Dec 22, 2012 at 5:00 PM, x17y19 <amber...@gmail.com> wrote:

Hi,

I'm getting an exception with this Ruby code:
--------------------
require 'sqlite3'

db = SQLite3::Database.open "/tmp/foo.db"

# execute contents of file
sql = IO.read 'bug.sql'
db.execute_batch sql
db.close
-------------------------

The file bug.sql has this in it:
----------------------------
-- demonstrate bug in sqlite3 ruby gem

CREATE TABLE IF NOT EXISTS foo ( id int );
-- comment at the end causes problems
---------------------------

Is the above literally what the file contains?  Can you post a gist that reproduces the problem?

I suspect an exception is being raised, the statement is closed, and the ensure block is executed before the exception can be raised to you:

  https://github.com/luislavena/sqlite3-ruby/blob/master/lib/sqlite3/database.rb#L96-98

If you can post a gist of the bug.sql file, I think I can fix this.

--
Aaron Patterson
http://tenderlovemaking.com/

[x17y19]

Sure, here is the gist:

https://gist.github.com/4375588/8791a734f853169b75dd1d1e4ee30d05e3d2c7c8

Thanks.

[Aaron Patterson]

On Tue, Dec 25, 2012 at 1:49 PM, x17y19 <amber...@gmail.com> wrote:

Sure, here is the gist:

https://gist.github.com/4375588/8791a734f853169b75dd1d1e4ee30d05e3d2c7c8

Thanks.  I've fixed the problem here:

  https://github.com/luislavena/sqlite3-ruby/commit/af493aa937b0e89b79eec1f1ebcc03bc00b1e9e9

I need to figure out how to test on windows, and then we should do a release.