[sqlite-dev] SQLite 3.28.0: Test failures with ICU: like3-6.110 like3-6.120 like3-6.210 like3-6.220

[Arfrever Frehtes Taifersar Arahesis]

SQLite 3.28.0 fails 4 tests when support for ICU is enabled (-DSQLITE_ENABLE_ICU):
like3-6.110 like3-6.120 like3-6.210 like3-6.220

SQLite configuration:

export CPPFLAGS=" -DSQLITE_ENABLE_API_ARMOR -DSQLITE_ENABLE_COLUMN_METADATA -DSQLITE_ENABLE_DBPAGE_VTAB -DSQLITE_ENABLE_DBSTAT_VTAB -DSQLITE_ENABLE_DESERIALIZE -DSQLITE_ENABLE_EXPLAIN_COMMENTS -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_HIDDEN_COLUMNS -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_MEMSYS5 -DSQLITE_ENABLE_NORMALIZE -DSQLITE_ENABLE_OFFSET_SQL_FUNC -DSQLITE_ENABLE_PREUPDATE_HOOK -DSQLITE_ENABLE_RBU -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_GEOPOLY -DSQLITE_ENABLE_STMT_SCANSTATUS -DSQLITE_ENABLE_STMTVTAB -DSQLITE_ENABLE_UNKNOWN_SQL_FUNCTION -DSQLITE_ENABLE_UNLOCK_NOTIFY -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT -DSQLITE_INTROSPECTION_PRAGMAS -DSQLITE_SOUNDEX -DSQLITE_USE_URI -DSQLITE_ENABLE_ICU -DSQLITE_SECURE_DELETE"
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --enable-load-extension --enable-threadsafe --enable-fts5 --enable-session --disable-debug --disable-editline --enable-readline --with-readline-inc=-I/usr/include/readline --disable-static --enable-tcl

Gentoo GNU/Linux, glibc 2.29, GCC 8.3.0, Tcl 8.6.9, ICU 64.2

Output of test suite:

...
Time: lastinsert.test 65 ms
Time: laststmtchanges.test 60 ms
(93 ms - want less than 1000) Time: like.test 140 ms
Time: like2.test 217 ms
! like3-6.110 expected: [
QUERY PLAN
`--SEARCH TABLE t1 USING PRIMARY KEY (path>? AND path<?)
]
! like3-6.110 got: [
QUERY PLAN
`--SCAN TABLE t1
]
! like3-6.120 expected: [
QUERY PLAN
`--SEARCH TABLE t1 USING PRIMARY KEY (path>? AND path<?)
]
! like3-6.120 got: [
QUERY PLAN
`--SCAN TABLE t1
]
! like3-6.210 expected: [
QUERY PLAN
`--SEARCH TABLE t2 USING INDEX t2path (path>? AND path<?)
]
! like3-6.210 got: [
QUERY PLAN
`--SCAN TABLE t2
]
! like3-6.220 expected: [
QUERY PLAN
`--SEARCH TABLE t2 USING INDEX t2path (path>? AND path<?)
]
! like3-6.220 got: [
QUERY PLAN
`--SCAN TABLE t2
]
Time: like3.test 63 ms
Time: limit.test 185 ms
Time: limit2.test 92 ms
...

I suspect that you will decide to just disable these tests...
('ifcapable !icu { ... }')

--
Arfrever Frehtes Taifersar Arahesis
_______________________________________________
sqlite-dev mailing list
sqlit...@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-dev

[Dan Kennedy]

On 26/4/62 06:40, Arfrever Frehtes Taifersar Arahesis wrote:
> SQLite 3.28.0 fails 4 tests when support for ICU is enabled (-DSQLITE_ENABLE_ICU):
> like3-6.110 like3-6.120 like3-6.210 like3-6.220
>
>

> I suspect that you will decide to just disable these tests...
> ('ifcapable !icu { ... }')

I think you've somehow ended up with an old copy of the test suite.
Those tests have had an "ifcapable !icu" around them since September 2017.

Dan.

[Arfrever Frehtes Taifersar Arahesis]

Dan Kennedy <danie...@gmail.com> wrote on 2019-04-26 15:50 UTC:
> On 26/4/62 06:40, Arfrever Frehtes Taifersar Arahesis wrote:
>> SQLite 3.28.0 fails 4 tests when support for ICU is enabled
>> (-DSQLITE_ENABLE_ICU):
>> like3-6.110 like3-6.120 like3-6.210 like3-6.220
>>
>>
>> I suspect that you will decide to just disable these tests...
>> ('ifcapable !icu { ... }')
>
>
> I think you've somehow ended up with an old copy of the test suite.
> Those tests have had an "ifcapable !icu" around them since September 2017.

You must be looking at wrong tests.
The failing tests (like3-6.110, like3-6.120, like3-6.210, like3-6.220)
have been introduced in https://sqlite.org/src/info/6ae4b8c525f446dd
on 2019-02-27 and first released in SQLite 3.28.0.

In test/like3.test currently only like3-5.111 test has 'ifcapable !icu' guard:
https://sqlite.org/src/artifact/0ce2630e39e32e42

--
Arfrever Frehtes Taifersar Arahesis

[Dan Kennedy]

On 26/4/62 23:19, Arfrever Frehtes Taifersar Arahesis wrote:
> Dan Kennedy <danie...@gmail.com> wrote on 2019-04-26 15:50 UTC:
>> On 26/4/62 06:40, Arfrever Frehtes Taifersar Arahesis wrote:
>>> SQLite 3.28.0 fails 4 tests when support for ICU is enabled
>>> (-DSQLITE_ENABLE_ICU):
>>> like3-6.110 like3-6.120 like3-6.210 like3-6.220
>>>
>>>
>>> I suspect that you will decide to just disable these tests...
>>> ('ifcapable !icu { ... }')
>>
>> I think you've somehow ended up with an old copy of the test suite.
>> Those tests have had an "ifcapable !icu" around them since September 2017.
> You must be looking at wrong tests.
> The failing tests (like3-6.110, like3-6.120, like3-6.210, like3-6.220)
> have been introduced in https://sqlite.org/src/info/6ae4b8c525f446dd
> on 2019-02-27 and first released in SQLite 3.28.0.

Right you are of course. I was looking at similarly numbered tests in
"like.test", not "like3.test". Now fixed here:

  https://sqlite.org/src/info/af53c41a127c314c

Thanks,

Dan.