Rename __dropdown_field_names__ to __possible_field_names__?

[Moritz Schlarb]

Hey List,

What do you think about renaming the FormBase attribute
__dropdown_field_names__ to __possible_field_names__ like it is named
for FillerBase since both will most likely be set to the same values
since they have the same function?

Cheers,
Moritz

[Chris Perkins]

Okay for the next release.  I will have to update the docs in sprox.org.  I think there is a bitbucket for this.

Can you write a property that spews a deprecation warning and we will remove for 0.9?

-chris

--
You received this message because you are subscribed to the Google Groups "sprox" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sprox+un...@googlegroups.com.
To post to this group, send email to sp...@googlegroups.com.
Visit this group at http://groups.google.com/group/sprox?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[Moritz Schlarb]

Am Donnerstag, 23. Mai 2013 18:27:21 UTC+2 schrieb percious:

Okay for the next release.  I will have to update the docs in sprox.org.  I think there is a bitbucket for this.

:D Nope, the sproxdox are on your Github account! :D 

Can you write a property that spews a deprecation warning and we will remove for 0.9?

Sure! 

Also, I just thought about this:

Shouldn't __possible_field_names__ be able to accept a dictionary for those who want to be specific about which widget shall be shown by which attribute?

That could be easily done backwards compatible by using a list like before and using the new mode if its a dict!

Any objections on that?

[Chris Perkins]

all of this sounds great.  Please send me a push request and we will get it into master.

Can you provide your github account name and I will give you access to sproxdox?

please add unit tests for your code so that we may maintain 100% coverage for the suite.

thanks,

-chris

--

[Moritz Schlarb]

Ah, I just saw that this is already done with the __possible_field_names__!

Yes, I'll send you pull requests with tests, but maybe not today anymore ;)

My Github account is moschlar.

Thanks,

Moritz

[Chris Perkins]

you are added to sproxdox github.  Let me know if you have an update.  I would love it if we could also produce an updated coverage report.  You can usually get that from amol.

cheers.

-chris

[Alessandro Molina]

The current head on bitbucket is still 100% covered, there are a bunch of patches not merged in anyway due to missing tests

[Moritz Schlarb]

First part is ready:

https://bitbucket.org/percious/sprox/pull-request/5/allow-tablefiller__possible_field_names__/diff

[Moritz Schlarb]

Okay, this is also done: https://bitbucket.org/percious/sprox/pull-request/6/rename-formbase__dropdown_field_names__-to/diff

I'm sorry for the mess, Mercurial is f**king with my Githead...

Am Donnerstag, 23. Mai 2013 18:27:21 UTC+2 schrieb percious:

[Alessandro Molina]

Shouldn't __possible_field_name_defaults__ be something like a global POSSIBLE_FIELD_NAME_DEFAULTS? We are actually using them in multiple places and having both __possible_field_names__ and __possible_field_name_defaults__ as an option provides two ways to do the same thing. 

[Moritz Schlarb]

That is true, but they are set to (slightly) different values! :D

I wasn't sure if there could be a reason for it, but I think it would make much more sense if they were equal!

You received this message because you are subscribed to a topic in the Google Groups "sprox" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/sprox/0FA3jZN5ZMI/unsubscribe?hl=en.
To unsubscribe from this group and all its topics, send an email to sprox+un...@googlegroups.com.

To post to this group, send email to sp...@googlegroups.com.
Visit this group at http://groups.google.com/group/sprox?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

-- 
Moritz Schlarb