Testing sproutcore master

[Umberto Nicoletti]

I took some time today to test my app Mappu against Sproutcore master (I hope master is the right branch to check).

I meant to test it before the latest IRC meeting, but other things came up.

Good news first: the app does not break and it actually feels snappier. The panes look different in background color and

shadow, but that's ok. I was using the defaults anyway.

Lots of developer warnings in the console, expecially with regards to animation callbacks and timings.

Now the broccoli: there is a segmented view in the toolbar where the position of the first button is wrong. This seems to happen only on buttons

without icons because another segmented view with icons in all buttons looks ok (see the Livelli button in the second image).

It seems that the cause for the mis-alignment is a wrong font-size, but I can't find the exact change that broke it.

Picker panes appear in the wrong place (the one in the image should have appeared below the 'Livelli' button) and are missing the pointer anchor and the

contents in the top toolbar (a couple of radio buttons and buttons).

Also note that an html entity (à) appears escaped in another segmented view in the bottom right corner.

In the next few days I will try to look into these issues, but I shall make no promises.

Umberto

[Tyler Keating]

Thanks a lot Umberto, that's good information to have and I will also try to see if I can recreate/identify the problems.

--

Tyler Keating

ty...@sproutcore.com

--
You received this message because you are subscribed to the Google Groups "SproutCore Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sproutcore-de...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Umberto Nicoletti]

I did some more testing on the segmentedview issue and found out that:

1. it is not related to the item position (first, second, last, etc), but to the absence of an icon. All items without an icon will be off regardless of order. Please note that this affects also items used to expand a segmentedview that is too large for its container (i.e. the 'More' button).

2. the issue only seems to exist in google chrome (I'm on Linux, btw)

3. in Firefox/Linux the segmented view items all appear to be correctly positioned, regardless of icon. The icons themeselves are a little off, though, as shown in the following image

Hth,

Umberto

[Umberto Nicoletti]

I was able to track the segmented view issue to this commit:

https://github.com/sproutcore/sproutcore/commit/afbdb3ed46dbae6facce59b38e893a964005f00b

I reverted it on my fork and the issue went away on both chrome and firefox.

hth,

Umberto

[Umberto Nicoletti]

As for the new default behaviour of the labelRenderDelegate which escapes all text I propose

that the default regex is changed as per the following pr:

https://github.com/sproutcore/sproutcore/pull/1013

Cheers,

Umberto

[Dave Porter]

Hey Umberto – I took a look at the showcase app here (running locally on master on the default port) and the segmented view looked fine to me on Chrome/Mac. Are you seeing problems there?

[Umberto Nicoletti]

Dave, thanks for looking into it.

I tried but I cannot even get the app to load: it spits out a javascript error saying 'can't call create on undefined' (undefined is actually Ace.BaseTheme).

Perhaps I am doing it wrong, so here's what I tried:

cd frameworks/sproutcore

git checkout master

rm -rf tmp # just to be safe, as it wasn't there

sc-server

I have also tried using sc-server from a local bundle, still no success.

Umberto

[Umberto Nicoletti]

I just tried loading

http://showcase.sproutcore.com/#ui/SC.SegmentedView

in Firefox-Mac and it shows the icon/label misalignment that I wrote about earlier (notice the icon is noticeably lower than the label in the regular and large size). The button misalignment issue is not visible because there are no segmented views mixing buttons with and without icons.

Umberto

[Dave Porter]

I saw that too - it cleared up in chrome when I cleared the cache. Firefox I was unable to fix. So... yeah, is this something other folks are seeing on master right now?

[Topher Fangio]

I tested it on my version of Firefox-Mac as well and see the same issue.

Additionally, in all browsers, it looks like it is improperly escaping the html perhaps:

--

Topher Fangio

System Architect
Pharos Resources

office: 325.216.2908
mobile: 325.660.7141