1.7.1.beta (aka git master) and spriting issues: purple background on stock icons

[Umberto Nicoletti]

I have cloned SC from git just to test it out and I have noticed that *some* icons and buttons have a purple background.

For instance see the error alert pane from the test controls.

I did some debugging and found out that the size 48 error icon is in fact 48x47 pixels (instead of the expected 48x48).

The result is that the purple background, probably inserted on purpose by chance to make these errors stand out, is visible.

Question is: which one should be fixed? The css or the image?

(I vote for the image, btw).

Umberto

[Juan Camilo Pinzón]

css

[Chad Eubanks]

+ 1 for both CSS and image

Sent from my iPhone

[Wesley Workman]

+1 for CSS.

This is an important thing to get right. The width and height should
correctly match the size of the image. However it's also important the
element size correctly reflect a standard icon size. The solution is
to fill any difference in space with right or bottom margins (margins,
*not padding*). This will ensure the sprited images are correct
(preventing pink outlines) and will also prevent any unintended UI
changes by ensuring the elements remain the same size.

Umberto, If you would like to take on this task we'd greatly
appreciate it. However, if you do not, please open an issue and I'll
be happy to take care of it myself.



-- Wesley

On Feb 19, 3:18 pm, Chad Eubanks <chadcreat...@gmail.com> wrote:
> + 1 for both CSS and image
>
> Sent from my iPhone
>

[Umberto Nicoletti]

No problem, I can work on it this week. I'll open an issue anyway, just for tracking progress and discussion.

Cheers,

Umberto

[Umberto Nicoletti]

I have opened a pull request

https://github.com/sproutcore/sproutcore/pull/718

which is a duplicate of issue 717, sorry