OCM JCR

[Antony Stubbs]

Jason, was just about to start merging your patches, but saw something
a little confusing...

In commit 5a4d510e83ee86a79971364a921487b538ac2332, I saw that you
added spring-webmvc and JTA as a dependency to the JCR project? Is
this really correct?

Also, <spring.version>${version.spring}</spring.version> - should this
not be under dependency management in the super POM?

Looks like you've got a lot of tests - great!

Also a general note - in Git, the first line of the commit message is
taken as the 'subject'.

[Jason Thrasher]

Hi Antony,
Yes, those dependencies are required for the Jackrabbit OCM
components, particularly JTA. I don't recall the spring-webmvc
requirement off the top of my head as it's been a few weeks since the
change. But, yes, it's correct.

Yes, maybe spring.version could be refactored under the super POM.
I'd recommend getting it in for now, then making sure all subprojects
are in alignment.

Yes tests are good. :) Otherwise I'd go insane.

Git commit comments duly noted.

regards,
Jason

> <Screen shot 2009-10-01 at 11.35.11 AM.png>
>
>
> Cheers.

[Pablo Saavedra]

Once my changes are merged, you may just delete the <version> from the pom. In the meantime I'd leave it as it is now.

2009/9/30 Jason Thrasher <jasont...@gmail.com>

[Antony Stubbs]

Hi Jason, was just about to merge your code today and doh - doesn't build! And my apologies - I had you hudson instance miss-configured - it was building only the base tree, not yours! :/

http://sharca.com:8080/job/spring-modules%20thrasher/3/console

Could you have a look at it? I think it's basically a maven configuration issue... I also get the same error building it on my laptop - that's why i checked hudson...

> HUDSON] Archiving /var/lib/hudson/jobs/spring-modules thrasher/workspace/projects/spring-modules-jcr/pom.xml to /var/lib/hudson/jobs/spring-modules thrasher/modules/org.springmodules$spring-modules-jcr/builds/2009-12-10_03-33-20/archive/org.springmodules/spring-modules-jcr/0.10-SNAPSHOT/pom.xml
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Compilation failure
>
> /var/lib/hudson/jobs/spring-modules thrasher/workspace/projects/spring-modules-jcr/src/test/java/org/springmodules/jcr/jackrabbit/RmiTests.java:[20,31] package org.springframework.test does not exist
>
> /var/lib/hudson/jobs/spring-modules thrasher/workspace/projects/spring-modules-jcr/src/test/java/org/springmodules/jcr/jackrabbit/RmiTests.java:[26,30] cannot find symbol
> symbol: class AbstractTransactionalSpringContextTests
> public class RmiTests extends AbstractTransactionalSpringContextTests {

> --~--~---------~--~----~------------~-------~--~----~
> You received this message because you are subscribed to the Google Groups "spring-modules-fork" group.
> To post to this group, send email to spring-mo...@googlegroups.com
> To unsubscribe from this group, send email to spring-modules-...@googlegroups.com
> For more options, visit this group at http://groups.google.com/group/spring-modules-fork?hl=en
> -~----------~----~----~----~------~----~------~--~---
>

[davidkarlsen]

Hmm, replied to this but cannot find my answer.

I have a few branches:
bugfix: Fixes a test when running on IBM 1.5 JDKs due to Map iteration
order (cache module)
mvneclipseclean: remove .project/.settings/.classpath and ignore them
- let setup be generated from maven + a few best-practices (more to
come)
collectionsmultikeygen: A new key generator implementation based on
commons collections multikey implementation.
libupgrades: a few upgrades of libraries

Anthony: How about creating a spring30 branch for Spring 3.0 adaption
for the active modules?

[Antony Stubbs]

On 5/01/2010, at 10:09 AM, davidkarlsen wrote:
> Anthony: How about creating a spring30 branch for Spring 3.0 adaption
> for the active modules?

I think that's a great idea, once we've rebased against all the provided, good, patches - which I'm committed to doing this week :)